From 7465e0dd5d3b567076aa0cc8101c35eb26eab22f Mon Sep 17 00:00:00 2001 From: "http://www.cse.unsw.edu.au/~willu/" Date: Sun, 24 Aug 2008 17:29:52 -0400 Subject: [PATCH] Response --- ...list_available_pre-processor_commands.mdwn | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/doc/todo/Add_a_plugin_to_list_available_pre-processor_commands.mdwn b/doc/todo/Add_a_plugin_to_list_available_pre-processor_commands.mdwn index 951ebe999..e311addcd 100644 --- a/doc/todo/Add_a_plugin_to_list_available_pre-processor_commands.mdwn +++ b/doc/todo/Add_a_plugin_to_list_available_pre-processor_commands.mdwn @@ -114,9 +114,29 @@ I've found myself wanting to know which [[plugins]] are switched on so I know wh >>>>>>> links. The old patch is still here if you decide you prefer that. -- [[Will]] >>>>>>>> Can you explain the full/early list (why track both?) and generated parameter? + +>>>>>>>>> If you add in all the shortcuts you get quite a long list. My original idea +>>>>>>>>> was to just track the plugin commands. This is the early list. But then +>>>>>>>>> I thought that it might be nice for someone looking at wiki source and +>>>>>>>>> seeing a shortcut to know where it came from. So I decided to make +>>>>>>>>> displaying the full list an option, with the original concept as the default. + +>>>>>>>>> Another option here might be to generate the full list every time, but give +>>>>>>>>> generated pre-processor commands (e.g. shortcuts) a different css class. +>>>>>>>>> I'm not sure that is better than what I have though. + +>>>>>>>>> I keep track of both in the page state because if a command moves from +>>>>>>>>> a shortcut to the early list (or vice versa) it changes what should be +>>>>>>>>> displayed in the default use of the plugin. I thought about tracking just what +>>>>>>>>> was actually used on the page, but I don't know in the needsbuild hook whether the `generated` +>>>>>>>>> parameter has been supplied (or maybe the plugin is used twice on the page - +>>>>>>>>> once in each form). It was just easier to track both. + >>>>>>>> Only code change I'd suggest is using `htmllink` rather than >>>>>>>> generating a wikilink. +>>>>>>>>> Yeah - that would make sense. Will do. -- [[Will]] + #!/usr/bin/perl # Ikiwiki listpreprocessors plugin. package IkiWiki::Plugin::listpreprocessors; -- 2.26.2