From 739c5824f249aa2ba000a76aed2daf4f3d13be5f Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 6 Nov 2013 06:54:44 +2000 Subject: [PATCH] Re: [PATCH v2 07/11] lib: use the compaction backup path provided by the caller --- b2/32f9dfabec27439b3b4583553303ee34c92b77 | 65 +++++++++++++++++++++++ 1 file changed, 65 insertions(+) create mode 100644 b2/32f9dfabec27439b3b4583553303ee34c92b77 diff --git a/b2/32f9dfabec27439b3b4583553303ee34c92b77 b/b2/32f9dfabec27439b3b4583553303ee34c92b77 new file mode 100644 index 000000000..fddc36f81 --- /dev/null +++ b/b2/32f9dfabec27439b3b4583553303ee34c92b77 @@ -0,0 +1,65 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 158AB429E27 + for ; Tue, 5 Nov 2013 02:55:01 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id rDaEeungo7dR for ; + Tue, 5 Nov 2013 02:54:53 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 5F5F8431FBF + for ; Tue, 5 Nov 2013 02:54:53 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1VdeHY-0000nW-Bm; Tue, 05 Nov 2013 06:54:48 -0400 +Received: (nullmailer pid 10563 invoked by uid 1000); Tue, 05 Nov 2013 + 10:54:44 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 07/11] lib: use the compaction backup path provided by + the caller +In-Reply-To: + <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org> +References: + <6e8053834c8ab856c2ebab881069f18b2badcf71.1383481295.git.jani@nikula.org> +User-Agent: Notmuch/0.16+111~ga7964c8 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 05 Nov 2013 06:54:44 -0400 +Message-ID: <87ob5zqft7.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 05 Nov 2013 10:55:01 -0000 + +Jani Nikula writes: + +> + backup_path = talloc_asprintf (config, "%s/xapian.old", path); +> + if (! backup_path) +> + return 1; +> + + +Is it intentional that no message is printed here? A random glance at +notmuch-search.c suggests we usually print a message on OOM in the CLI. + +d -- 2.26.2