From 7380b68087a0b0d1740193c5af5a70b7bdf8a610 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Fri, 25 Sep 2015 09:13:43 +2100 Subject: [PATCH] Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default --- 65/8e79e383fc2392dcf294007f311a7daa1eb28e | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 65/8e79e383fc2392dcf294007f311a7daa1eb28e diff --git a/65/8e79e383fc2392dcf294007f311a7daa1eb28e b/65/8e79e383fc2392dcf294007f311a7daa1eb28e new file mode 100644 index 000000000..7eb4346c1 --- /dev/null +++ b/65/8e79e383fc2392dcf294007f311a7daa1eb28e @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id DFFE26DE0C1E + for ; Thu, 24 Sep 2015 05:15:03 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 0.112 +X-Spam-Level: +X-Spam-Status: No, score=0.112 tagged_above=-999 required=5 tests=[AWL=0.112] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id etwpv5qL3e04 for ; + Thu, 24 Sep 2015 05:15:01 -0700 (PDT) +Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id A39C06DE0B7C + for ; Thu, 24 Sep 2015 05:15:01 -0700 (PDT) +Received: from remotemail by gitolite.debian.net with local (Exim 4.80) + (envelope-from ) + id 1Zf5PY-0006cU-9f; Thu, 24 Sep 2015 12:14:04 +0000 +Received: (nullmailer pid 29080 invoked by uid 1000); Thu, 24 Sep 2015 + 12:13:43 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] make test: NOTMUCH_TEST_QUIET=1 is now the default +In-Reply-To: +References: <1442004251-32325-1-git-send-email-tomi.ollila@iki.fi> + <87io75tji3.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.20.2+73~gd432116 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Thu, 24 Sep 2015 09:13:43 -0300 +Message-ID: <87wpvguia0.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 24 Sep 2015 12:15:04 -0000 + +Tomi Ollila writes: +> +> There was 2 primary motivations when I did that patch (which I forgot to +> mark rfc although I thought doing so) 1) that was the fastest at the time +> being and 2) the --verbose is already in use in test-lib.sh. +> +> First thing that come to my mind is that if (-v|--v[e[r[b[o[s[e]]]]]]) +> option is for the suggested purpose its current behaviour is removed +> and when the option is not give user is informed how to activate "verbose" +> progress -- but as said that is just first thought... +> +> +> Making NOTMUCH_TEST_QUIET no-op is probably no annoyance to anyone... +> + +For the moment, I think this patch is good enough. Maybe we can make the +interaction with --verbose make more sense in the future, but it's +really an independant issue. + +d -- 2.26.2