From 72d37ef9bb3c354b8bc3417f925d9ff8bfe103a1 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 8 Sep 2015 09:51:04 +2100 Subject: [PATCH] Re: [PATCH 2/2] cli: reset db directory mtime upon directory removal --- 41/8755f4838fa0813daba9c3856fa2e88ebde4cb | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 41/8755f4838fa0813daba9c3856fa2e88ebde4cb diff --git a/41/8755f4838fa0813daba9c3856fa2e88ebde4cb b/41/8755f4838fa0813daba9c3856fa2e88ebde4cb new file mode 100644 index 000000000..7fbd4c7d2 --- /dev/null +++ b/41/8755f4838fa0813daba9c3856fa2e88ebde4cb @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id CC4106DE1760 + for ; Mon, 7 Sep 2015 05:51:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 2.68 +X-Spam-Level: ** +X-Spam-Status: No, score=2.68 tagged_above=-999 required=5 tests=[AWL=-1.010, + RCVD_IN_BRBL_LASTEXT=1.644, RCVD_IN_SBL=2.596, + RP_MATCHES_RCVD=-0.55] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wh845uUz9lop for ; + Mon, 7 Sep 2015 05:51:10 -0700 (PDT) +X-Greylist: delayed 317 seconds by postgrey-1.35 at arlo; + Mon, 07 Sep 2015 05:51:09 PDT +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + by arlo.cworth.org (Postfix) with ESMTPS id DDB086DE1734 + for ; Mon, 7 Sep 2015 05:51:09 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1ZYvt5-0002mF-Il; Mon, 07 Sep 2015 09:51:07 -0300 +Received: (nullmailer pid 23745 invoked by uid 1000); Mon, 07 Sep 2015 + 12:51:04 -0000 +From: David Bremner +To: Jani Nikula , Mark Walters , + notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] cli: reset db directory mtime upon directory removal +In-Reply-To: <1441445731-4362-2-git-send-email-jani@nikula.org> +References: <87siray6th.fsf@qmul.ac.uk> + <1441445731-4362-1-git-send-email-jani@nikula.org> + <1441445731-4362-2-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 07 Sep 2015 09:51:04 -0300 +Message-ID: <87egiaz93b.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 07 Sep 2015 12:51:11 -0000 + +Jani Nikula writes: + +> The library does not have a function to remove a directory document +> for a path. Usually this doesn't matter except for a slight waste of +> space. However, if the same directory gets added to the filesystem +> again, the old directory document is found with the old mtime. Reset +> the directory mtime on removal to avoid problems. +> + + +pushed to master. + +d -- 2.26.2