From 704787c53db93bbe9eb522d60dae898c7297452f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 1 Jan 2015 14:03:47 +0200 Subject: [PATCH] Re: [PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering --- cf/f13aff3536790f94106b402fc25501b5d69d02 | 84 +++++++++++++++++++++++ 1 file changed, 84 insertions(+) create mode 100644 cf/f13aff3536790f94106b402fc25501b5d69d02 diff --git a/cf/f13aff3536790f94106b402fc25501b5d69d02 b/cf/f13aff3536790f94106b402fc25501b5d69d02 new file mode 100644 index 000000000..9ac59cd31 --- /dev/null +++ b/cf/f13aff3536790f94106b402fc25501b5d69d02 @@ -0,0 +1,84 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 40CE8431FC7 + for ; Thu, 1 Jan 2015 04:04:23 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 5YcNRz8pn8OB for ; + Thu, 1 Jan 2015 04:04:20 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id EC7A9431FC0 + for ; Thu, 1 Jan 2015 04:04:19 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 5F802100051; + Thu, 1 Jan 2015 14:03:47 +0200 (EET) +From: Tomi Ollila +To: David Bremner , Michal Sojka , + notmuch@notmuchmail.org +Subject: Re: [PATCH v3 10/10] cli: address: Add --filter-by option + to configure address filtering +In-Reply-To: <87vbkrfs66.fsf@maritornes.cs.unb.ca> +References: <1415147159-19946-1-git-send-email-sojkam1@fel.cvut.cz> + <1415147159-19946-11-git-send-email-sojkam1@fel.cvut.cz> + <87vbkrfs66.fsf@maritornes.cs.unb.ca> +User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 01 Jan 2015 12:04:23 -0000 + +On Wed, Dec 31 2014, David Bremner wrote: + +> Michal Sojka writes: +> +>> This option allows to configure the criterion for duplicate address +>> filtering. Without this option, all unique combinations of name and +>> address parts are printed. This option allows to filter the output +>> more, for example to only contain unique address parts. +> +> I had the feeling there was some "controversy" about the UI here, but +> following back the 3 versions of the series I didn't see it. Does that +> mean we just need to sanity check the code, or are there outstanding +> bikes to shed? + +I have intentionally been guiet on this during the review process of the +other patches to not slow down the acceptance of the others. I have not +got enough time to look the implemenentation or think this last patch +further -- from the user interface point of view I recall seeing there +both useless features (but which might be warranted by implementation +simplicity) and missing features (but which might not be there due to +difficulty in implementation). Also, I am not sure whether the --filter-by +is good option (and options descriptive...)... + +...I'll look into this soon.... + + +> +> d + +Tomi -- 2.26.2