From 6cf4ad043cde3939af42bbeafdd618b89099a076 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Mon, 2 Mar 2015 19:47:03 +0200 Subject: [PATCH] [PATCH 3/4] test: extract and flag second rounding tests as broken --- 89/5a2feb12fda157e624dee279d6af4eef7db055 | 110 ++++++++++++++++++++++ 1 file changed, 110 insertions(+) create mode 100644 89/5a2feb12fda157e624dee279d6af4eef7db055 diff --git a/89/5a2feb12fda157e624dee279d6af4eef7db055 b/89/5a2feb12fda157e624dee279d6af4eef7db055 new file mode 100644 index 000000000..2ccab64b9 --- /dev/null +++ b/89/5a2feb12fda157e624dee279d6af4eef7db055 @@ -0,0 +1,110 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id A4D50429E41 + for ; Mon, 2 Mar 2015 10:30:57 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.738 +X-Spam-Level: * +X-Spam-Status: No, score=1.738 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id CS-fSdGxA-Iz for ; + Mon, 2 Mar 2015 10:30:54 -0800 (PST) +Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com + [74.125.82.50]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client + certificate requested) by olra.theworths.org (Postfix) with ESMTPS id + 17AEB414B86 for ; Mon, 2 Mar 2015 09:49:32 -0800 + (PST) +Received: by wghn12 with SMTP id n12so35093173wgh.1 + for ; Mon, 02 Mar 2015 09:46:52 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to + :references; + bh=YYGPQwZyQLwQnR/FCFztPCauFxWqujng3ah7GFYV5ZE=; + b=YooDChFDJoB1zbShA8E2h8cInacJ6adWJbfOmdykQJg/Yy4HuKJSUH0/9MCZ0vhkgj + acAHVzYpmHBuuwUqqDmH102DEdksQQ3IgHC7KtJJLFCDlseI3CRGna3dDMx9yoPpFgOw + tJEP7+XCk7o2QDjdD+PwP2ROnbWv2aUtrgJpkMUs6qXzkjqNRthUDwcCZa9hLK3J6cEW + YfyuENXnQxvWaMAMEV7awJHTf+eTIb8HWMRHXEfs3+nORMRLHJvLqYSGVGWxM076rJX3 + 9/WUo/Es8GHLKX4nMuzqYp3HsqzmmPxhEgrhoiBGMrm7UHqE77UaCRzalD8YQH+2LMsc + QFWw== +X-Gm-Message-State: + ALoCoQkemXStd1j8mIo65X2KD2OzWaGIQqnO38CLvCDg+g68ebc4QushqgGBrBIEN8U6ZkuYd/6N +X-Received: by 10.180.82.103 with SMTP id h7mr19861933wiy.30.1425318412010; + Mon, 02 Mar 2015 09:46:52 -0800 (PST) +Received: from localhost (mobile-internet-bcee3b-76.dhcp.inet.fi. + [188.238.59.76]) by mx.google.com with ESMTPSA id + s19sm16990950wik.18.2015.03.02.09.46.50 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Mon, 02 Mar 2015 09:46:51 -0800 (PST) +From: Jani Nikula +To: notmuch@notmuchmail.org +Subject: [PATCH 3/4] test: extract and flag second rounding tests as broken +Date: Mon, 2 Mar 2015 19:47:03 +0200 +Message-Id: <1425318424-27017-3-git-send-email-jani@nikula.org> +X-Mailer: git-send-email 2.1.4 +In-Reply-To: <1425318424-27017-1-git-send-email-jani@nikula.org> +References: <1425318424-27017-1-git-send-email-jani@nikula.org> +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Mar 2015 18:30:58 -0000 + +Extract and add some more tests relating to rounding seconds into a +separate subtest, and flag it as broken. If seconds are not specified, +the time is not set or rounded according to the interface defined in +parse-time-string/parse-time-string.h. Instead, seconds are always set +to 00 in reality, which is broken. +--- + test/T490-parse-time-string.sh | 16 ++++++++++++++-- + 1 file changed, 14 insertions(+), 2 deletions(-) + +diff --git a/test/T490-parse-time-string.sh b/test/T490-parse-time-string.sh +index ca3ecb4036ed..9247bdf89543 100755 +--- a/test/T490-parse-time-string.sh ++++ b/test/T490-parse-time-string.sh +@@ -40,8 +40,6 @@ two mo ==> Thu Nov 11 12:13:14 +0000 2010 + 5m ==> Tue Jan 11 12:08:14 +0000 2011 + dozen mi ==> Tue Jan 11 12:01:14 +0000 2011 + 8am ==> Tue Jan 11 08:00:00 +0000 2011 +-9:15 ==> Tue Jan 11 09:15:00 +0000 2011 +-12:34 ==> Tue Jan 11 12:34:00 +0000 2011 + monday ==> Mon Jan 10 12:13:14 +0000 2011 + yesterday ==> Mon Jan 10 12:13:14 +0000 2011 + tomorrow ==> ERROR: KEYWORD +@@ -80,4 +78,18 @@ EOF + ${TEST_DIRECTORY}/parse-time --ref=${REFERENCE} < INPUT > OUTPUT + test_expect_equal_file INPUT OUTPUT + ++test_begin_subtest "Second rounding tests" ++test_subtest_known_broken ++REFERENCE=$(_date Tue Jan 11 12:13:14 +0000 2011) ++cat < INPUT ++9:15 ==> Tue Jan 11 09:15:14 +0000 2011 ++12:34 ==> Tue Jan 11 12:34:14 +0000 2011 ++10:30 ==> Tue Jan 11 10:30:14 +0000 2011 ++10:30 ==^> Tue Jan 11 10:30:59 +0000 2011 ++10:30 ==^^> Tue Jan 11 10:31:00 +0000 2011 ++10:30 ==_> Tue Jan 11 10:30:00 +0000 2011 ++EOF ++${TEST_DIRECTORY}/parse-time --ref=${REFERENCE} < INPUT > OUTPUT ++test_expect_equal_file INPUT OUTPUT ++ + test_done +-- +2.1.4 + -- 2.26.2