From 6b936454f7c6b0c89bf2cc9baa371c7141030751 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 21 May 2013 17:17:37 +0300 Subject: [PATCH] Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX() --- 24/badaff30fa889a474f2a9e3628dfffb58cbd2c | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 24/badaff30fa889a474f2a9e3628dfffb58cbd2c diff --git a/24/badaff30fa889a474f2a9e3628dfffb58cbd2c b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c new file mode 100644 index 000000000..0747e6b8b --- /dev/null +++ b/24/badaff30fa889a474f2a9e3628dfffb58cbd2c @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 8B724431FC7 + for ; Tue, 21 May 2013 07:17:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id g-H4i88JfAMy for ; + Tue, 21 May 2013 07:17:38 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 4C6DA431FB6 + for ; Tue, 21 May 2013 07:17:38 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id A50D21002C3; + Tue, 21 May 2013 17:17:37 +0300 (EEST) +From: Tomi Ollila +To: Felipe Contreras , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX() +In-Reply-To: <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com> +References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com> + <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com> +User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: Ali Polatel +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 21 May 2013 14:17:42 -0000 + +On Mon, May 20 2013, Felipe Contreras wrote: + +> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are +> loaded lazily, so nobody would notice unless they try +> 'query::count_messages'. +> +> Signed-off-by: Felipe Contreras + +This patch could be pushed on it's own, but someone (like Ali) could +comment on the change as searches on both UINT2FIX() & UINT2NUM() +provides (IMH) insatisfactory results... + +Tomi + +> --- +> bindings/ruby/query.c | 2 +- +> 1 file changed, 1 insertion(+), 1 deletion(-) +> +> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c +> index e5ba1b7..1658ede 100644 +> --- a/bindings/ruby/query.c +> +++ b/bindings/ruby/query.c +> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self) +> * (function may return 0 after printing a message) +> * Thus there is nothing we can do here... +> */ +> - return UINT2FIX(notmuch_query_count_messages(query)); +> + return UINT2NUM(notmuch_query_count_messages(query)); +> } +> -- +> 1.8.3.rc3.286.g3d43083 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2