From 6ad1f8b018dd0f4c2236f565e64e218870337201 Mon Sep 17 00:00:00 2001 From: Zac Medico Date: Tue, 4 Aug 2009 00:13:08 +0000 Subject: [PATCH] Add a PDEPEND.suspect category. svn path=/main/trunk/; revision=13884 --- bin/repoman | 8 +++++--- man/repoman.1 | 3 +++ 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/bin/repoman b/bin/repoman index 6569cc364..8e0b8e428 100755 --- a/bin/repoman +++ b/bin/repoman @@ -284,6 +284,7 @@ qahelp={ "DEPEND.badmaskedindev":"Masked ebuilds with bad DEPEND settings (matched against *all* ebuilds) in developing arch", "RDEPEND.badmaskedindev":"Masked ebuilds with RDEPEND settings (matched against *all* ebuilds) in developing arch", "PDEPEND.badmaskedindev":"Masked ebuilds with PDEPEND settings (matched against *all* ebuilds) in developing arch", + "PDEPEND.suspect":"PDEPEND contains a package that usually only belongs in DEPEND.", "DEPEND.syntax":"Syntax error in DEPEND (usually an extra/missing space/parenthesis)", "RDEPEND.syntax":"Syntax error in RDEPEND (usually an extra/missing space/parenthesis)", "PDEPEND.syntax":"Syntax error in PDEPEND (usually an extra/missing space/parenthesis)", @@ -342,6 +343,7 @@ qawarnings = set(( "KEYWORDS.stupid", "KEYWORDS.missing", "IUSE.undefined", +"PDEPEND.suspect", "RDEPEND.implicit", "RDEPEND.suspect", "RESTRICT.invalid", @@ -1430,11 +1432,11 @@ for x in scanlist: portage.dep_getkey(atom) == "virtual/jdk": stats['java.eclassesnotused'] += 1 fails['java.eclassesnotused'].append(relative_path) - elif mytype == "RDEPEND": + elif mytype in ("PDEPEND", "RDEPEND"): if not is_blocker and \ portage.dep_getkey(atom) in suspect_rdepend: - stats['RDEPEND.suspect'] += 1 - fails['RDEPEND.suspect'].append( + stats[mytype + '.suspect'] += 1 + fails[mytype + '.suspect'].append( relative_path + ": '%s'" % atom) if eapi == "0": if portage.dep.dep_getslot(atom): diff --git a/man/repoman.1 b/man/repoman.1 index 555ff3995..13383a423 100644 --- a/man/repoman.1 +++ b/man/repoman.1 @@ -161,6 +161,9 @@ Masked ebuilds with PDEPEND settings (matched against *all* ebuilds) .B PDEPEND.badmaskedindev Masked ebuilds with PDEPEND settings (matched against *all* ebuilds) in developing arch .TP +.B PDEPEND.suspect +PDEPEND contains a package that usually only belongs in DEPEND +.TP .B PDEPEND.syntax Syntax error in PDEPEND (usually an extra/missing space/parenthesis) .TP -- 2.26.2