From 6982ccecaf32ebf8adfcb66b4225da3b46255621 Mon Sep 17 00:00:00 2001 From: Jari Aalto Date: Sat, 29 Sep 2007 23:34:19 -0700 Subject: [PATCH] git-remote: exit with non-zero status after detecting error in "rm". Exit with non-zero status when "git remote rm" was told to remove a non-existing remote. Signed-off-by: Jari Aalto Signed-off-by: Junio C Hamano --- git-remote.perl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/git-remote.perl b/git-remote.perl index 79941e40f..9ca3e7ef3 100755 --- a/git-remote.perl +++ b/git-remote.perl @@ -322,7 +322,7 @@ sub rm_remote { my ($name) = @_; if (!exists $remote->{$name}) { print STDERR "No such remote $name\n"; - return; + return 1; } $git->command('config', '--remove-section', "remote.$name"); @@ -337,13 +337,13 @@ sub rm_remote { } }; - my @refs = $git->command('for-each-ref', '--format=%(refname) %(objectname)', "refs/remotes/$name"); for (@refs) { ($ref, $object) = split; $git->command(qw(update-ref -d), $ref, $object); } + return 0; } sub add_usage { @@ -461,7 +461,7 @@ elsif ($ARGV[0] eq 'rm') { print STDERR "Usage: git remote rm \n"; exit(1); } - rm_remote($ARGV[1]); + exit(rm_remote($ARGV[1])); } else { print STDERR "Usage: git remote\n"; -- 2.26.2