From 683f37794a81d30e9e6a039ea1fbe031751ef453 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Mon, 26 Aug 2013 23:07:16 +0300 Subject: [PATCH] Re: [PATCH 0/2] contrib: pick: remove sync parser --- 25/8e461122097afcc51857b979557034656e943d | 88 +++++++++++++++++++++++ 1 file changed, 88 insertions(+) create mode 100644 25/8e461122097afcc51857b979557034656e943d diff --git a/25/8e461122097afcc51857b979557034656e943d b/25/8e461122097afcc51857b979557034656e943d new file mode 100644 index 000000000..59f679100 --- /dev/null +++ b/25/8e461122097afcc51857b979557034656e943d @@ -0,0 +1,88 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 47D08431FD4 + for ; Mon, 26 Aug 2013 13:07:27 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 8qpUzkL7B+sW for ; + Mon, 26 Aug 2013 13:07:23 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id D8BA9431FAF + for ; Mon, 26 Aug 2013 13:07:22 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id D96DD100030; + Mon, 26 Aug 2013 23:07:16 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] contrib: pick: remove sync parser +In-Reply-To: <1377547043-17584-1-git-send-email-markwalters1009@gmail.com> +References: <1377547043-17584-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+36~g947c286 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Aug 2013 20:07:27 -0000 + +On Mon, Aug 26 2013, Mark Walters wrote: + +> Pick has two possible parsing methods: a synchronous one (like show) +> and an async one (like search). The async parser has been the default +> since at least the time pick first entered contrib. I don't believe +> there have been any reported problems with it during this time so we +> might as well remove the sync parser and the associated defcustom. We +> also remove the sync tests. + +LGTM (and +1 for the code loss :) + +> +> Best wishes +> +> Mark + +Tomi +> +> +> +> +> Mark Walters (2): +> contrib: pick: remove sync parser +> contrib: pick: remove sync tests +> +> contrib/notmuch-pick/notmuch-pick.el | 36 +++++----------- +> contrib/notmuch-pick/run-tests.sh | 2 +- +> contrib/notmuch-pick/test/emacs-pick-sync | 64 ----------------------------- +> 3 files changed, 12 insertions(+), 90 deletions(-) +> delete mode 100755 contrib/notmuch-pick/test/emacs-pick-sync +> +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2