From 67b13e52de16f127356189314556f5701ba05d8e Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 1 Apr 2015 09:15:10 +0200 Subject: [PATCH] Re: [PATCH] notmuch-emacs-mua: non-forking escape () usage with backslash '\' escape --- 43/4818d50afec5b96361660acc9f1831985c5095 | 66 +++++++++++++++++++++++ 1 file changed, 66 insertions(+) create mode 100644 43/4818d50afec5b96361660acc9f1831985c5095 diff --git a/43/4818d50afec5b96361660acc9f1831985c5095 b/43/4818d50afec5b96361660acc9f1831985c5095 new file mode 100644 index 000000000..3613f9f3d --- /dev/null +++ b/43/4818d50afec5b96361660acc9f1831985c5095 @@ -0,0 +1,66 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 3FEB26DE1983 + for ; Fri, 3 Apr 2015 16:03:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.236 +X-Spam-Level: * +X-Spam-Status: No, score=1.236 tagged_above=-999 required=5 tests=[AWL=0.432, + DATE_IN_PAST_12_24=0.804] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id gu5q47rQW6wR for ; + Fri, 3 Apr 2015 16:03:25 -0700 (PDT) +Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net + [87.98.215.224]) + by arlo.cworth.org (Postfix) with ESMTPS id A4EBA6DE1978 + for ; Fri, 3 Apr 2015 16:03:25 -0700 (PDT) +Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim + 4.80) (envelope-from ) + id 1YdXFY-0003S2-OG; Thu, 02 Apr 2015 05:01:05 +0000 +Received: (nullmailer pid 2040 invoked by uid 1000); Wed, 01 Apr 2015 + 07:15:10 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH] notmuch-emacs-mua: non-forking escape () usage with + backslash '\' escape +In-Reply-To: <1427647054-7773-1-git-send-email-tomi.ollila@iki.fi> +References: <1427647054-7773-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.19+96~g703c8f9 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Wed, 01 Apr 2015 09:15:10 +0200 +Message-ID: <871tk448w1.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 03 Apr 2015 23:03:28 -0000 + +Tomi Ollila writes: + +> Use the printf -v convention to give output variable as argument +> to escape () function so no subshell needs to be executed for +> escaping input. The '-v' option to escape () is just syntactic +> sugar for better understanding. +> +> Also, backslash is now escaped with another backslash for emacs. This +> ie especially important at the end of string. +> + +s/ie/is/, but I can amend that. Otherwise looks ok. + +d -- 2.26.2