From 67777b973a824889ce3ec40fe382b17e2d904c19 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 30 Mar 2014 08:03:49 +0100 Subject: [PATCH] Re: [PATCH] emacs: push mark before signature on reply --- 1e/a1f8a988baa6433f7fcfe9357cf927feefa404 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 1e/a1f8a988baa6433f7fcfe9357cf927feefa404 diff --git a/1e/a1f8a988baa6433f7fcfe9357cf927feefa404 b/1e/a1f8a988baa6433f7fcfe9357cf927feefa404 new file mode 100644 index 000000000..9c0f14b09 --- /dev/null +++ b/1e/a1f8a988baa6433f7fcfe9357cf927feefa404 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 24E36431FBD + for ; Sun, 30 Mar 2014 00:04:07 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -1.098 +X-Spam-Level: +X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dxDi2anXo5dt for ; + Sun, 30 Mar 2014 00:03:59 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 55872431FBC + for ; Sun, 30 Mar 2014 00:03:59 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WU9mY-0000Wh-E9; Sun, 30 Mar 2014 08:03:54 +0100 +Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WU9mY-0001fJ-4m; Sun, 30 Mar 2014 08:03:50 +0100 +From: Mark Walters +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: push mark before signature on reply +In-Reply-To: <1396029865-23133-1-git-send-email-jani@nikula.org> +References: <1396029865-23133-1-git-send-email-jani@nikula.org> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 30 Mar 2014 08:03:49 +0100 +Message-ID: <878ursqiay.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 93.97.24.31 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: d8cb88f468d37a763dbf8bd63a298f99 (of first 20000 bytes) +X-SpamAssassin-Score: 0.0 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored 0.0 points. Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * 0.0 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 30 Mar 2014 07:04:07 -0000 + + +LGTM +1 + +Best wishes + +Mark + +On Fri, 28 Mar 2014, Jani Nikula wrote: +> We push mark on reply so user can cut the quote. Push the mark before +> signature, if any, instead of end of buffer so the signature is +> preserved. +> +> This is consistent with message-kill-to-signature. +> --- +> emacs/notmuch-mua.el | 6 +++++- +> 1 file changed, 5 insertions(+), 1 deletion(-) +> +> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +> index b16a10ecd379..ba3ef275ec5e 100644 +> --- a/emacs/notmuch-mua.el +> +++ b/emacs/notmuch-mua.el +> @@ -226,8 +226,12 @@ list." +> ;; Quote the original message according to the user's configured style. +> (message-cite-original)))) +> +> - (goto-char (point-max)) +> + ;; Push mark right before signature, if any. +> + (message-goto-signature) +> + (unless (eobp) +> + (end-of-line -1)) +> (push-mark) +> + +> (message-goto-body) +> (set-buffer-modified-p nil)) +> +> -- +> 1.9.0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch + -- 2.26.2