From 6775fa1946878f17fc1468682b2d5d20789fa1c0 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sat, 1 Jun 2013 09:50:40 +0300 Subject: [PATCH] Re: [PATCH v3 0/6] Make Emacs search use sexp format --- be/44755d3d0abd06eab273ad59c889e1a7e676f4 | 120 ++++++++++++++++++++++ 1 file changed, 120 insertions(+) create mode 100644 be/44755d3d0abd06eab273ad59c889e1a7e676f4 diff --git a/be/44755d3d0abd06eab273ad59c889e1a7e676f4 b/be/44755d3d0abd06eab273ad59c889e1a7e676f4 new file mode 100644 index 000000000..33ea8e16c --- /dev/null +++ b/be/44755d3d0abd06eab273ad59c889e1a7e676f4 @@ -0,0 +1,120 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 37875429E3C + for ; Fri, 31 May 2013 23:50:51 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id V-7egyRW-Lzp for ; + Fri, 31 May 2013 23:50:42 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id B17F4431FDE + for ; Fri, 31 May 2013 23:50:42 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 5EEF0100086 + for ; Sat, 1 Jun 2013 09:50:40 +0300 (EEST) +From: Tomi Ollila +To: notmuch@notmuchmail.org +Subject: Re: [PATCH v3 0/6] Make Emacs search use sexp format +In-Reply-To: <1370047208-12785-1-git-send-email-amdragon@mit.edu> +References: <1370047208-12785-1-git-send-email-amdragon@mit.edu> +User-Agent: Notmuch/0.15.2+115~g12cf6af (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 01 Jun 2013 06:50:51 -0000 + +On Sat, Jun 01 2013, Austin Clements wrote: + +> This is v3 of id:1369934016-22308-1-git-send-email-amdragon@mit.edu. +> This tweaks the shell invocation as suggested by Tomi and fixes two +> comment typos pointed out by Mark. It also adds a NEWS patch. I'm +> going to go ahead and mark this ready because of Tomi's and Mark's +> reviews of v2. + ++1 + +Tomi + + +> +> The diff from v2 follows +> +> diff --git a/NEWS b/NEWS +> index 80abd97..2a4bde6 100644 +> --- a/NEWS +> +++ b/NEWS +> @@ -66,6 +66,17 @@ notmuch-vim, but of course that is their decision. +> Emacs Interface +> --------------- +> +> +Better handling of errors in search buffers +> + +> + Instead of interleaving errors in search result buffers, search mode +> + now reports errors in the minibuffer. +> + +> +Faster search results +> + +> + Communication between search mode and the notmuch CLI is now more +> + efficient because it uses the CLI's S-expression support. As a +> + result, search mode should now fill search buffers faster. +> + +> No Emacs 22 support +> +> The Emacs 22 support added late 2010 was sufficient only for a short +> diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el +> index 180f63d..a206808 100644 +> --- a/emacs/notmuch-lib.el +> +++ b/emacs/notmuch-lib.el +> @@ -497,8 +497,8 @@ status." +> (command (or (executable-find notmuch-command) +> (error "command not found: %s" notmuch-command))) +> (proc (apply #'start-process name buffer +> - "sh" "-c" +> - "ERR=\"$1\"; shift; exec \"$0\" \"$@\" 2>\"$ERR\"" +> + "/bin/sh" "-c" +> + "exec 2>\"$1\"; shift; exec \"$0\" \"$@\"" +> command err-file args))) +> (process-put proc 'err-file err-file) +> (process-put proc 'sub-sentinel sentinel) +> @@ -533,8 +533,8 @@ status." +> (when warnings +> (notmuch-logged-error (car warnings) (cdr warnings))))) +> (error +> - ;; Emacs behaves strangely if error an error escapes from a +> - ;; sentinel, so turns errors into messages. +> + ;; Emacs behaves strangely if an error escapes from a sentinel, +> + ;; so turn errors into messages. +> (message "%s" (error-message-string err)))) +> (ignore-errors (delete-file err-file)))) +> +> +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2