From 668a8eecc6f38342f6cce2a5952ca27274fafd7c Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 25 Aug 2013 20:50:12 +0100 Subject: [PATCH] [Patch (rebased) 0/2] contrib: pick: remove an unused variable --- 08/70cba8ce9d15f855960cda99aef91413eb730b | 86 +++++++++++++++++++++++ 1 file changed, 86 insertions(+) create mode 100644 08/70cba8ce9d15f855960cda99aef91413eb730b diff --git a/08/70cba8ce9d15f855960cda99aef91413eb730b b/08/70cba8ce9d15f855960cda99aef91413eb730b new file mode 100644 index 000000000..a50f864da --- /dev/null +++ b/08/70cba8ce9d15f855960cda99aef91413eb730b @@ -0,0 +1,86 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 78192431FC7 + for ; Mon, 26 Aug 2013 11:05:45 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.7 +X-Spam-Level: ** +X-Spam-Status: No, score=2.7 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_ENVFROM_END_DIGIT=1, FREEMAIL_FROM=0.001, + FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id OhpIBp5SoFrB for ; + Mon, 26 Aug 2013 11:05:38 -0700 (PDT) +Received: from mail-we0-f179.google.com (mail-we0-f179.google.com + [74.125.82.179]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B8A24431FAF + for ; Mon, 26 Aug 2013 11:05:37 -0700 (PDT) +Received: by mail-we0-f179.google.com with SMTP id t58so2939774wes.24 + for ; Mon, 26 Aug 2013 11:05:36 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:cc:subject:date:message-id; + bh=DPks5bEv1w/GY6HpxKJv1Mtnf2MNQ44xdCVhyrfBwkE=; + b=zV4bVHreXImkO6zNAvV6xHFdG0GkvrbTIDXUtn4i2zdcJVvQTeXhlBiSX1BNxvcD1R + AJA6kLcuCyTYW6Vn6mguho4zd+pPG5t1WXRVILRu1Rwg1MqljCdtMECYwEQ2ub9IpYG0 + QLwIN+7CvmWw0MTMqO3MBdCSTXX94YlMDURgHF34QP7V7CqYBqkTD6kCi9KJuGRH1k7h + 9SOqfmZ2n1whT85WlNzzWIFUfBshy01/yKEwVr+kR78xxgc3yF5hCcoMlNYFds7xJjg/ + wBuRBczfQhaLW5zv5uPo6Y2vXv5zfDYN1QpgT6WFeQkbahnLZRl0nZDWznwGrA8qpxHX + bBQQ== +X-Received: by 10.180.182.15 with SMTP id ea15mr5073629wic.16.1377460218601; + Sun, 25 Aug 2013 12:50:18 -0700 (PDT) +Received: from localhost (93-97-24-31.zone5.bethere.co.uk. [93.97.24.31]) + by mx.google.com with ESMTPSA id v9sm13221442wiw.8.1969.12.31.16.00.00 + (version=TLSv1.2 cipher=RC4-SHA bits=128/128); + Sun, 25 Aug 2013 12:50:18 -0700 (PDT) +From: Mark Walters +To: notmuch@notmuchmail.org +Subject: [Patch (rebased) 0/2] contrib: pick: remove an unused variable +Date: Sun, 25 Aug 2013 20:50:12 +0100 +Message-Id: <1377460214-4795-1-git-send-email-markwalters1009@gmail.com> +X-Mailer: git-send-email 1.7.9.1 +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 26 Aug 2013 18:05:45 -0000 + +This is a rebased version of +id:1372712861-13515-1-git-send-email-markwalters1009@gmail.com. + +When documenting notmuch-pick-worker I realised that +notmuch-pick-buffer-name was an essentially unused argument: it is +only used to reset itself on refresh. + +(Possibly this was a mis-copy from notmuch-show or possibly a left +over from refesh used kill-buffer instead of erase-buffer.) + +In any case we might as well remove it and then document the function. + +Best wishes + +Mark + +Mark Walters (2): + contrib: pick: remove unneeded variable notmuch-pick-buffer-name + contrib: pick: add docstring for notmuch-pick-worker + + contrib/notmuch-pick/notmuch-pick.el | 19 ++++++++----------- + 1 files changed, 8 insertions(+), 11 deletions(-) + +-- +1.7.9.1 + -- 2.26.2