From 65c5b095257675763683ed8f4d6519bf37169419 Mon Sep 17 00:00:00 2001
From: Tomi Ollila <tomi.ollila@iki.fi>
Date: Sat, 23 Jan 2016 18:33:36 +0200
Subject: [PATCH] Re: [PATCH] test: refactor directory name sanitization

---
 96/8d3c8d1b5242e850ba142b08e23dc6913ac1a8 | 118 ++++++++++++++++++++++
 1 file changed, 118 insertions(+)
 create mode 100644 96/8d3c8d1b5242e850ba142b08e23dc6913ac1a8

diff --git a/96/8d3c8d1b5242e850ba142b08e23dc6913ac1a8 b/96/8d3c8d1b5242e850ba142b08e23dc6913ac1a8
new file mode 100644
index 000000000..9a98d14b4
--- /dev/null
+++ b/96/8d3c8d1b5242e850ba142b08e23dc6913ac1a8
@@ -0,0 +1,118 @@
+Return-Path: <tomi.ollila@iki.fi>
+X-Original-To: notmuch@notmuchmail.org
+Delivered-To: notmuch@notmuchmail.org
+Received: from localhost (localhost [127.0.0.1])
+ by arlo.cworth.org (Postfix) with ESMTP id 399EA6DE119D
+ for <notmuch@notmuchmail.org>; Sat, 23 Jan 2016 08:33:31 -0800 (PST)
+X-Virus-Scanned: Debian amavisd-new at cworth.org
+X-Spam-Flag: NO
+X-Spam-Score: 0.658
+X-Spam-Level: 
+X-Spam-Status: No, score=0.658 tagged_above=-999 required=5 tests=[AWL=0.006, 
+ SPF_NEUTRAL=0.652] autolearn=disabled
+Received: from arlo.cworth.org ([127.0.0.1])
+ by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
+ with ESMTP id giHmxt9wqY0Q for <notmuch@notmuchmail.org>;
+ Sat, 23 Jan 2016 08:33:28 -0800 (PST)
+Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
+ by arlo.cworth.org (Postfix) with ESMTP id 9993B6DE0B27
+ for <notmuch@notmuchmail.org>; Sat, 23 Jan 2016 08:33:27 -0800 (PST)
+Received: from guru.guru-group.fi (localhost [IPv6:::1])
+ by guru.guru-group.fi (Postfix) with ESMTP id EC32610004A;
+ Sat, 23 Jan 2016 18:33:36 +0200 (EET)
+From: Tomi Ollila <tomi.ollila@iki.fi>
+To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
+Subject: Re: [PATCH] test: refactor directory name sanitization
+In-Reply-To: <1453553366-7454-1-git-send-email-david@tethera.net>
+References: <1453553366-7454-1-git-send-email-david@tethera.net>
+User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
+ (x86_64-unknown-linux-gnu)
+X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
+ $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
+ !)g;OY^,BjTbr)Np:%c_o'jj,Z
+Date: Sat, 23 Jan 2016 18:33:36 +0200
+Message-ID: <m2mvrws1b3.fsf@guru.guru-group.fi>
+MIME-Version: 1.0
+Content-Type: text/plain
+X-BeenThere: notmuch@notmuchmail.org
+X-Mailman-Version: 2.1.20
+Precedence: list
+List-Id: "Use and development of the notmuch mail system."
+ <notmuch.notmuchmail.org>
+List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
+List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
+List-Post: <mailto:notmuch@notmuchmail.org>
+List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
+List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
+ <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
+X-List-Received-Date: Sat, 23 Jan 2016 16:33:31 -0000
+
+On Sat, Jan 23 2016, David Bremner <david@tethera.net> wrote:
+
+> test_C and notmuch_search_files_sanitize were giving different output on
+> the same path, which is not technically wrong, but slightly
+> confusing.
+> ---
+>  test/T560-lib-error.sh |  2 +-
+>  test/test-lib.sh       | 11 ++++++++---
+>  2 files changed, 9 insertions(+), 4 deletions(-)
+>
+> diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh
+> index c280939..59a479c 100755
+> --- a/test/T560-lib-error.sh
+> +++ b/test/T560-lib-error.sh
+> @@ -183,7 +183,7 @@ int main (int argc, char** argv)
+>  EOF
+>  cat <<'EOF' >EXPECTED
+>  == stdout ==
+> -Path already exists: CWD/mail
+> +Path already exists: MAIL_DIR
+>  
+>  == stderr ==
+>  EOF
+> diff --git a/test/test-lib.sh b/test/test-lib.sh
+> index 0c9b366..c8f14d9 100644
+> --- a/test/test-lib.sh
+> +++ b/test/test-lib.sh
+> @@ -684,9 +684,14 @@ notmuch_search_sanitize ()
+>      perl -pe 's/("?thread"?: ?)("?)................("?)/\1\2XXX\3/'
+>  }
+>  
+> -notmuch_search_files_sanitize()
+> +notmuch_search_files_sanitize ()
+>  {
+> -    sed -e "s,$MAIL_DIR,MAIL_DIR,"
+> +    notmuch_dir_sanitize
+> +}
+> +
+> +notmuch_dir_sanitize ()
+> +{
+> +    sed -e  "s,$MAIL_DIR,MAIL_DIR," -e "s,${PWD},CWD,g" "$@"
+
+Looks good,  ^^ \ but 2 spaces there
+
+>  }
+>  
+>  NOTMUCH_SHOW_FILENAME_SQUELCH='s,filename:.*/mail,filename:/XXX/mail,'
+> @@ -1186,7 +1191,7 @@ test_C () {
+>      echo "== stdout ==" > OUTPUT.stdout
+>      echo "== stderr ==" > OUTPUT.stderr
+>      ./${exec_file} "$@" 1>>OUTPUT.stdout 2>>OUTPUT.stderr
+> -    sed "s,${PWD},CWD,g"  OUTPUT.stdout OUTPUT.stderr > OUTPUT
+> +    notmuch_dir_sanitize  OUTPUT.stdout OUTPUT.stderr > OUTPUT
+
+Ditto, although this was th^^ere before, but now these 2 could be amended.
+
+BTW: I trust you tested. I did not.
+
+Tomi
+
+
+BTW2: MAIL_DIR is based on user's current CWD(*) -- if that contains commas
+(,) then things will break ;/
+
+(*) +++(./test-lib-common.sh:148): MAIL_DIR=/home/user/vc/ext/notmuch/test/tmp.test-verbose/mail
+
+
+
-- 
2.26.2