From 62f077c97ad59438e90e5b4ebe8584d871fe55bf Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Thu, 25 Sep 2014 14:28:39 +1700 Subject: [PATCH] Re: [PATCH v2] lib: Simplify close and codify aborting atomic section --- 64/534016a1dffb9e1ca3950b9e597aeb5367ea64 | 136 ++++++++++++++++++++++ 1 file changed, 136 insertions(+) create mode 100644 64/534016a1dffb9e1ca3950b9e597aeb5367ea64 diff --git a/64/534016a1dffb9e1ca3950b9e597aeb5367ea64 b/64/534016a1dffb9e1ca3950b9e597aeb5367ea64 new file mode 100644 index 000000000..c0b2bf588 --- /dev/null +++ b/64/534016a1dffb9e1ca3950b9e597aeb5367ea64 @@ -0,0 +1,136 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 426FD431FBC + for ; Wed, 24 Sep 2014 14:28:52 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id Fl2uzYBgj2FH for ; + Wed, 24 Sep 2014 14:28:44 -0700 (PDT) +Received: from resqmta-po-03v.sys.comcast.net (resqmta-po-03v.sys.comcast.net + [96.114.154.162]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 7C3CB431FAF + for ; Wed, 24 Sep 2014 14:28:44 -0700 (PDT) +Received: from resomta-po-10v.sys.comcast.net ([96.114.154.234]) + by resqmta-po-03v.sys.comcast.net with comcast + id v9UN1o00853iAfU019UhXK; Wed, 24 Sep 2014 21:28:41 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by resomta-po-10v.sys.comcast.net with comcast + id v9Ug1o008152l3L019Ugak; Wed, 24 Sep 2014 21:28:41 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id 8092113BA82D; Wed, 24 Sep 2014 14:28:39 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1411594119; bh=YAjWMlgfXWwq57BUOwEEgQh3JiuBWcT0T70CWrFcXWY=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=anMjYFbFo6fvb/GyJHalXiZwh7zQdA+rap09I7WUO8s3FZieCXPEtW3UexlBrC+p8 + 3Q63a7FTpDeie55p4Ot0YScl3rP3ZoGU6quv+V3QHRElu+/m4nlToo97/2v0A90O2E + wqwBfEYx+zoF3WYyaV8LqYjrTJ3TKexPeBQliqh0= +Date: Wed, 24 Sep 2014 14:28:39 -0700 +From: "W. Trevor King" +To: Austin Clements +Subject: Re: [PATCH v2] lib: Simplify close and codify aborting atomic section +Message-ID: <20140924212839.GE20130@odin.tremily.us> +References: <1411400615-20934-1-git-send-email-amdragon@mit.edu> + <1411593623-8234-1-git-send-email-aclements@csail.mit.edu> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="bi5JUZtvcfApsciF" +Content-Disposition: inline +In-Reply-To: <1411593623-8234-1-git-send-email-aclements@csail.mit.edu> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1411594121; + bh=rMOQ3yEKm3DgTw/zjJW/2c2TdT11KS0kq3ZJAivHI24=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=klce0uEmdiczhG4l0NFGAtXjPRS6ZVDuciFxXyPzKknO74f+fh3oqixe4PBb+Wl+Z + mWU3eX+zpO3qJZgjUW4krDEarEu8LGS9VPw/hP6k8yWXdbAuNT/7lcP5yE+SAO700C + D/q5+3pD/GP7fmhVvWjYBSo2eZXLWVIJm8h044n17qI/3rHtLTSJJlv/LhtDbSGXc2 + kaLU5/37kyc6kB/mh69vqBzjwGr1ds4DfdoVHtgYaZWNbjfbArLApcNjgmp9MekCd+ + fKmrH5hDCq+E3XTPFB88sGRtH625prYG1mlE+Qpd4V8eEMp2xDb3s9H3BVMJ9UYcUD + dKcgF7uBO9MUw== +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 24 Sep 2014 21:28:52 -0000 + + +--bi5JUZtvcfApsciF +Content-Type: text/plain; charset=utf-8 +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Wed, Sep 24, 2014 at 05:20:23PM -0400, Austin Clements wrote: +> diff --git a/lib/notmuch.h b/lib/notmuch.h +> index fe2340b..5c40c67 100644 +> --- a/lib/notmuch.h +> +++ b/lib/notmuch.h +> @@ -292,6 +292,11 @@ notmuch_database_open (const char *path, +> * notmuch_database_close can be called multiple times. Later calls +> * have no effect. +> * +> + * If the caller is currently in an atomic section (there was a +> + * notmuch_database_begin_atomic without a matching +> + * notmuch_database_end_atomic), this will abort the atomic section, +> + * discarding any modifications made in the atomic section. +> + * +> * Return value: +> * +> * NOTMUCH_STATUS_SUCCESS: Successfully closed the database. + +Still no mention of =E2=80=9Ccommit=E2=80=9D or =E2=80=9Cif you're not in a= +n atomic section=E2=80=9D +;). + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--bi5JUZtvcfApsciF +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2 + +iQIcBAEBAgAGBQJUIzeFAAoJEG8/JgBt8ol8Tx0P/39hs7vds2rIYlcdwtD2CvAT +eRzfIN7zYAFqvRolWkil7hc96Ylod2LFDr9xQRmugCuThk17TDlQ/MB3a71+VvK9 +UinuSgZy30zI1pJN/wSGERsBIKMmotW03nJKXFf8nRRsAD7yyycvRM0LLXgSbasu +Gba8YT9IxN5Ko6mK28ETGP0tboJflqz9NDK3MIyfY0xsXCeAkYTLEVhec5VlzbJM +JKlYZ5Hfm76GHuGOey8b404Ye6eQRI8ZbWld7IIBzCYAAnfV2KFrSH/Qa5VOWZ5b +d7mhdpX7Wmmxvfly2DK51ItOO/oz5E87ZoFcnWbK3ESuKpGCmYV/R1EdCBY2Pba2 +2ORAIOw/QFxvPygIntuCsGt0T0WRJytcwcyN03Brr/aDZrWGcFuyZiW3n5j9yYEX +B36+GUMDSJn9nVcHL1rM6ucudlULo667T1wNTSGYUL5mhuUs8m9ihsan/pYrWpyV +syHVoeh/wjyoPLUj9WTcBUyf6VPAYZ0/MqzZB8NM83By+u9J9FY85Tztw62w6SvI +rsEl7BardxRfs3qQbAc8JUzXgtv7mJnaggr5W13mAhciBemMgDwoQwYGORrhpAMm +ZRAu04aF5Zgee9vVGSxM2IZNTcIlaYkXAh6o7AzRdG+wLZXIhBE4ppyos9v3yH0o +7/y8isp/TIfvQWofZ9rp +=+UBI +-----END PGP SIGNATURE----- + +--bi5JUZtvcfApsciF-- -- 2.26.2