From 6058972e5a53803f816c009cf3214fcc5acffb2e Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Mon, 2 Jun 2014 14:43:46 +0100 Subject: [PATCH] Re: [PATCH v1] emacs: Forwarded messages should not have modified buffers --- 77/df1436d1c4c1ec817111d8d251034dabbd1412 | 121 ++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 77/df1436d1c4c1ec817111d8d251034dabbd1412 diff --git a/77/df1436d1c4c1ec817111d8d251034dabbd1412 b/77/df1436d1c4c1ec817111d8d251034dabbd1412 new file mode 100644 index 000000000..b1369231c --- /dev/null +++ b/77/df1436d1c4c1ec817111d8d251034dabbd1412 @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 158EB431FCF + for ; Mon, 2 Jun 2014 06:44:04 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id cRG0tBLmhojp for ; + Mon, 2 Jun 2014 06:43:56 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 2ACDC431FAF + for ; Mon, 2 Jun 2014 06:43:56 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WrSWh-0001Qw-NO; Mon, 02 Jun 2014 14:43:50 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WrSWh-0003uD-DR; Mon, 02 Jun 2014 14:43:47 +0100 +From: Mark Walters +To: Tomi Ollila , David Edmondson , + notmuch@notmuchmail.org +Subject: Re: [PATCH v1] emacs: Forwarded messages should not have modified + buffers +In-Reply-To: +References: + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (i486-pc-linux-gnu) +Date: Mon, 02 Jun 2014 14:43:46 +0100 +Message-ID: <87fvjns9yl.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 082e401dce81a078229c08050def5d0b (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Jun 2014 13:44:04 -0000 + +Tomi Ollila writes: + +> On Mon, Jun 02 2014, David Edmondson wrote: +> +>> When the user begins forwarding a message, the resulting composition +>> buffer should not be marked as modified, in order that it can +>> immediately be killed without prompting. +>> --- +> +> LGTM. +> +> Tomi + +and me. +1 + +Mark + +> +> +>> emacs/notmuch-mua.el | 3 ++- +>> 1 file changed, 2 insertions(+), 1 deletion(-) +>> +>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el +>> index 95e4a4d..2c58886 100644 +>> --- a/emacs/notmuch-mua.el +>> +++ b/emacs/notmuch-mua.el +>> @@ -346,7 +346,8 @@ the From: address first." +>> (message-forward-make-body cur) +>> ;; `message-forward-make-body' shows the User-agent header. Hide +>> ;; it again. +>> - (message-hide-headers))) +>> + (message-hide-headers) +>> + (set-buffer-modified-p nil))) +>> +>> (defun notmuch-mua-new-reply (query-string &optional prompt-for-sender reply-all) +>> "Compose a reply to the message identified by QUERY-STRING. +>> -- +>> 2.0.0.rc2 +>> +>> _______________________________________________ +>> notmuch mailing list +>> notmuch@notmuchmail.org +>> http://notmuchmail.org/mailman/listinfo/notmuch +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2