From 5f0c2cd769a481092a3a877c935abcf92f23411d Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 12 Apr 2016 22:28:44 +2100 Subject: [PATCH] Re: [PATCH v4 7/7] complete ghost-on-removal-when-shared-thread-exists --- ef/641b4812e223784056c927299f3fe1c2e85f60 | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 ef/641b4812e223784056c927299f3fe1c2e85f60 diff --git a/ef/641b4812e223784056c927299f3fe1c2e85f60 b/ef/641b4812e223784056c927299f3fe1c2e85f60 new file mode 100644 index 000000000..8b4ab4986 --- /dev/null +++ b/ef/641b4812e223784056c927299f3fe1c2e85f60 @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 498EE6DE012F + for ; Mon, 11 Apr 2016 18:28:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.017 +X-Spam-Level: +X-Spam-Status: No, score=-0.017 tagged_above=-999 required=5 + tests=[AWL=-0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ki3772sXJuuR for ; + Mon, 11 Apr 2016 18:28:50 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 3A9646DE0127 + for ; Mon, 11 Apr 2016 18:28:50 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1apn8R-0003iM-21; Mon, 11 Apr 2016 21:28:55 -0400 +Received: (nullmailer pid 20964 invoked by uid 1000); + Tue, 12 Apr 2016 01:28:44 -0000 +From: David Bremner +To: Daniel Kahn Gillmor , + Notmuch Mail +Cc: Austin Clements +Subject: Re: [PATCH v4 7/7] complete + ghost-on-removal-when-shared-thread-exists +In-Reply-To: <87zit0t0mj.fsf@alice.fifthhorseman.net> +References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net> + <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net> + <87r3ed6l35.fsf@zancas.localnet> <87zit0t0mj.fsf@alice.fifthhorseman.net> +User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 11 Apr 2016 22:28:44 -0300 +Message-ID: <87wpo362er.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 12 Apr 2016 01:28:58 -0000 + +Daniel Kahn Gillmor writes: + + +> I don't think this reasoning is sensible. If the entire thread is +> deleted, and a new message comes in, it should *not* get the same mesage +> ID. ghosts should only exist in the database when other messages point +> to them. +> +> So i'd be fine with killing this entire last test, unless someone can +> propose a good reason to keep it. + +I think I buy your reasoning, but I'd be happy if Austin (who introduced +ghost messages, and wrote that test, could comment. + +d -- 2.26.2