From 5e6e237624eb73c583916d5fea987f3b1572d073 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Fri, 9 May 2014 13:05:09 +0100 Subject: [PATCH] Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages --- 6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 | 121 ++++++++++++++++++++++ 1 file changed, 121 insertions(+) create mode 100644 6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 diff --git a/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 b/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 new file mode 100644 index 000000000..06fb55f1d --- /dev/null +++ b/6f/0d74f3ad7b94482ed15acf1d963c30e4505b40 @@ -0,0 +1,121 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 0B035431FBF + for ; Fri, 9 May 2014 05:05:22 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id nnUN8BsD+uiN for ; + Fri, 9 May 2014 05:05:14 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 1B9E7431FBC + for ; Fri, 9 May 2014 05:05:14 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1WijY6-0005Nw-3D; Fri, 09 May 2014 13:05:12 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1WijY5-0001Ey-Oz; Fri, 09 May 2014 13:05:09 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: [PATCH v1 0/3] emacs: Allow saving of threads and messages +In-Reply-To: <1399623743-30478-1-git-send-email-dme@dme.org> +References: <1399623743-30478-1-git-send-email-dme@dme.org> +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 09 May 2014 13:05:09 +0100 +Message-ID: <877g5vb1je.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: f6657b2bef40f4b75c5d63e6c2fb2dda (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 09 May 2014 12:05:22 -0000 + + +Hi + +I think the functionality is well worth having ("|" cat - > a-file is +ugly!). However, I am not sure about this approach. + +The first two patches are fine, although I think I like constructing a +query then quoting rather than quoting bits of a query and bolting them +together (even the both work). + +My concern is that the current approach gives the user no warning if +they are about to overwrite an existing file, and that this is true +regardless of any emacs settings. + +Could we do these saves by loading into a temporary buffer and then +using the normal emacs save buffer functions? That way we get the +benefit of emacs's normal query-overwrite, and respect any user +customizations of that. + +The only potential problem is to make sure we don't do any accidental +charset conversion. I guess this functionality is probably easy to test +at least! + +Best wishes + +Mark + + + +On Fri, 09 May 2014, David Edmondson wrote: +> emacs: Allow saving of threads and messages +> +> Similar to the pipe (|) support, allow saving of threads and messages. +> +> +> David Edmondson (3): +> emacs: Fix indentation. +> emacs: Minor re-work of `notmuch-show-pipe-message' +> emacs: Add `notmuch-show-save-message' to save messages +> +> emacs/notmuch-show.el | 161 ++++++++++++++++++++++++++++---------------------- +> 1 file changed, 91 insertions(+), 70 deletions(-) +> +> -- +> 2.0.0.rc0 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2