From 5e36264dbc0570045e5598498ca298acc5fc2059 Mon Sep 17 00:00:00 2001 From: "W. Trevor King" Date: Wed, 23 Apr 2014 17:18:24 +1700 Subject: [PATCH] Re: Thanks for the nmbug-status program --- b1/bdb2e37941ab12b222e60a045e82dbfe958ef0 | 188 ++++++++++++++++++++++ 1 file changed, 188 insertions(+) create mode 100644 b1/bdb2e37941ab12b222e60a045e82dbfe958ef0 diff --git a/b1/bdb2e37941ab12b222e60a045e82dbfe958ef0 b/b1/bdb2e37941ab12b222e60a045e82dbfe958ef0 new file mode 100644 index 000000000..f9625a858 --- /dev/null +++ b/b1/bdb2e37941ab12b222e60a045e82dbfe958ef0 @@ -0,0 +1,188 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 45247431FBF + for ; Tue, 22 Apr 2014 17:18:31 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.1 +X-Spam-Level: +X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id c1kOG1JAuLxZ for ; + Tue, 22 Apr 2014 17:18:27 -0700 (PDT) +Received: from qmta07.westchester.pa.mail.comcast.net + (qmta07.westchester.pa.mail.comcast.net [76.96.62.64]) + by olra.theworths.org (Postfix) with ESMTP id 1A6BB431FBD + for ; Tue, 22 Apr 2014 17:18:27 -0700 (PDT) +Received: from omta08.westchester.pa.mail.comcast.net ([76.96.62.12]) + by qmta07.westchester.pa.mail.comcast.net with comcast + id tBYH1n00D0Fqzac57CJS8T; Wed, 23 Apr 2014 00:18:26 +0000 +Received: from odin.tremily.us ([24.18.63.50]) + by omta08.westchester.pa.mail.comcast.net with comcast + id tCJR1n00C152l3L3UCJRBn; Wed, 23 Apr 2014 00:18:26 +0000 +Received: by odin.tremily.us (Postfix, from userid 1000) + id B0071116A1DB; Tue, 22 Apr 2014 17:18:24 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin; + t=1398212304; bh=WjSdiys3S969wKM9oVODfn7ajtzh6QERRONrgBPZ/ac=; + h=Date:From:To:Cc:Subject:References:In-Reply-To; + b=p4W/B1EbqwtuKZ5bghV3vb14mLunwd8e1S9Mm3VQtMsUEyPSXHiNL7u87GHguKpWA + AvwuEkO0LpG3haJBTzdUVJ6CdeVITqnUoWAuIfQfocTQrfjyMwTuCUFL7eriYcdoFO + ra8XOvtuZsZRY/1T/zIdT1flMnn7dPPlYvRRyuos= +Date: Tue, 22 Apr 2014 17:18:24 -0700 +From: "W. Trevor King" +To: Carl Worth +Subject: Re: Thanks for the nmbug-status program +Message-ID: <20140423001824.GM9243@odin.tremily.us> +References: <87eh0prrup.fsf@yoom.home.cworth.org> + <20140422213442.GI9243@odin.tremily.us> + <8761m1rmtp.fsf@yoom.home.cworth.org> +MIME-Version: 1.0 +Content-Type: multipart/signed; micalg=pgp-sha1; + protocol="application/pgp-signature"; boundary="QeIEYJGnsH0eC7HY" +Content-Disposition: inline +In-Reply-To: <8761m1rmtp.fsf@yoom.home.cworth.org> +OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8; + url=http://tremily.us/pubkey.txt +User-Agent: Mutt/1.5.23 (2014-03-12) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; + s=q20140121; t=1398212306; + bh=Wn/1HspDThe2dWZgowNeZU1VQLJ3LOMHsw7pfKxnd2Q=; + h=Received:Received:Received:Date:From:To:Subject:Message-ID: + MIME-Version:Content-Type; + b=A0g0ZJ0uV0PXYdPnIIXcUIVuyB/YqoKfw6ElIM0tBRa6r6S/YqLdLS61JbNifC6QK + 8fXIcLh+0Icff2vv1253XsLlBroRAjzkAecY77kJfANskFi0yYgPPWJIxdaxsjhWYD + sEK0M33VslubMz+vfkwfHWbkEl0m4b9He9ZfG19w/tUpIkNypva7ehQylBBmGmXWtf + h4lGXdrcADOi1uNPXJe+4ESWKQwRe19Bq41VNz9yS/Z/TUEXNBQiMW2HSgGZb++Yiz + OVfSU8O4UovYzHN8r1w4aAPMyQvhq375mL5uz0wSBqmSBy4KpjW9b5MZ7dhFPovrfY + c4BAmdD5o235g== +Cc: Notmuch List +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 23 Apr 2014 00:18:31 -0000 + + +--QeIEYJGnsH0eC7HY +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +Content-Transfer-Encoding: quoted-printable + +On Tue, Apr 22, 2014 at 04:01:06PM -0700, Carl Worth wrote: +> W. Trevor King writes: +> > I think that making nmbug and nmbug-status generally applicable for +> > other projects is a good target. I don't see any need to pull them +> > out into a stand-alone project to do that though. +>=20 +> For what it's worth, I don't disagree. + +Does that mean your patches are aimed upstream at the notmuch +repository? If so, you should probably mail them to the list for +discussion. Here are my initial reactions from reading the Git +history: + +* bcc677a Add initial notmuch-to-html script + +This is a side effect of pulling the script out into it's own repo and +doesn't need to be upstreamed. + +* fb9f586 Add explicit license information + +Another side effect of pulling the script out, but I like direct +license references. Someone using the script may not want to track +down a chain of references to figure out what the license is. + +* 9b8c173 Add copy of the GNU General Public License + +Doesn't need to be upstreamed. + +* 7d7ce23 Make the configuration file a required argument. + +I liked the "fall back to $NMBGIT's config:status-config.json" +functionality. I also think it generalizes well to parallel use for +multiple projects. For example, if I was maintaining a "Mesa Stable +Queue", I'd suggest folks use: + + $ NMBGIT=3D~/.config/mesa-stable-queue nmbug + $ NMBGIT=3D~/.config/mesa-stable-queue nmbug-status + +(or their shell's approriate environment variable syntax), and I'd +version the config file in the same repo as the associated tags. I +don't see the point of keeping the config file somewhere else, when +you'll already need a repository to store the tags. + +* d456390 Add a comment describing the program + +I like the idea, but I'd prefer a docstring just after the leading +comment. Then we could reuse the docstring as the description for the +ArgumentParser. + +* 336411f Add "notmuch search" to the advertised queries. + +Folks can already copy-paste the terms into Emacs etc. You only need +the 'notmuch search' prefix if you're pasting into a shell, in which +case you'll also want to escape shell-sensitive characters like +parenthesis. I'm fine without this one. + +* 9fd6177 Move the generated date from the top of the page to the footer. + +I like this. Part of me wants nmbug-status to use an actual +templating package (e.g. Jinja) for this sort of thing, but we can put +that off and stick with the hard-coded template as long as we keep +agreeing on the layout ;). + +* f55ff7e Drop the --get-query option + +I'd like to keep the in-Git config, so I'm -1 here. + +* 396869c Add support for a --query option (along with a default configurat= +ion) + +I don't have an opinion about this one ;). The default config doesn't +look very useful (especially with it's dummy metadata settings), but +I'd only be using the in-Git-config approach, and I don't mind if +others want something like this. + +Cheers, +Trevor + +--=20 +This email may be signed or encrypted with GnuPG (http://www.gnupg.org). +For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy + +--QeIEYJGnsH0eC7HY +Content-Type: application/pgp-signature; name="signature.asc" +Content-Description: OpenPGP digital signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v2.0.22 (GNU/Linux) + +iQIcBAEBAgAGBQJTVwbOAAoJEKKfehoaNkbtSNAP/A6OsihIq5cUT0sUjD2fNRpT +tOh813wU9S7AuGYQ+6DtWNXnW0r7KPCQ8SbKmLuRPcQkRqRdsOetVCYEwc+mxUzp +anUU1/9PPHUvAftdoItQIL2olKgX9N9XcgE8h1EHA+5huRG59fNsr/3bPu6E8tqB +0cNUY5V9YxzwXEQ6hOwtgOqutjsEJZVIEZRRRPEf8DOOa58r+gbyAnVb8nvSQYSe +e49Cx3BpfCdn5FrgyBHdWOJ+HBfKXDMHDvx2iOyyxt+4iiMgxzwQM4FD59/jHfSG +AKkJpEcCOK+pKZ1cLg4WkGCWawbyFe7MPhPipkZL6zrfQoCV3atKpJjLYmtdR39l +BUr1VH0u/bjio+obB+hsg2NoadL7H2/+V+W4LimwWjU1j+BIHLHSXhIRrOjRmtBb +dtSDYVKYeCaPZb5fERbZP9NNYZEoaB5cjACRiGgHCfWjF9umFdV+P/QgH5/Iq8NP +eVCWQd2awsYFLMI4BluzXdtF9sN6X1kepKXqkNmI+zpl4g3ZLayiL+soIXmWs3W4 +B9p8IuHI/yKeROn9YhZnqh6kh6+VWAhWsaz33l5MPDBSQZuEof+CH+hr4oSlKFO8 +RH7jerA/opVa3G2Z0aTMvuS+beGudH9hU/SKl/0zDwSvpw9/DgsJFM6puW2pijf0 +4kynhcOyt2nU6PcfhnGb +=wqt3 +-----END PGP SIGNATURE----- + +--QeIEYJGnsH0eC7HY-- -- 2.26.2