From 5e0dc6ef0d730bf2cbb5eb553aad11a2c8cace91 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Wed, 28 May 2014 09:25:18 +0300 Subject: [PATCH] Re: notmuch new: emails with BOM are ignored --- 5c/224223f3b055656cbb7331e6bbf41cb18ae964 | 85 +++++++++++++++++++++++ 1 file changed, 85 insertions(+) create mode 100644 5c/224223f3b055656cbb7331e6bbf41cb18ae964 diff --git a/5c/224223f3b055656cbb7331e6bbf41cb18ae964 b/5c/224223f3b055656cbb7331e6bbf41cb18ae964 new file mode 100644 index 000000000..0fe8c326c --- /dev/null +++ b/5c/224223f3b055656cbb7331e6bbf41cb18ae964 @@ -0,0 +1,85 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5B947431FC0 + for ; Tue, 27 May 2014 23:25:28 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id UrlhHGfnF7QP for ; + Tue, 27 May 2014 23:25:23 -0700 (PDT) +Received: from mail-we0-f173.google.com (mail-we0-f173.google.com + [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 3D9D8431FB6 + for ; Tue, 27 May 2014 23:25:23 -0700 (PDT) +Received: by mail-we0-f173.google.com with SMTP id u57so10854035wes.32 + for ; Tue, 27 May 2014 23:25:22 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=guIzAZ9lA/3rL5aenWpBXaq6tI9DoaIJ/ocVVMKj3+M=; + b=kOQeyyy5UnYSq8gqKZ1KeCDfZFB9ebjdR96cVp/16yuIy7Vzcd3aR6+5qVbdE7eS+w + pFPBYCoedqt8wUkmsKNgdyyjYG0BQhByQ8Y4udR+aLdpBjDUKjQynRdGHWzgC9xqqQLf + QRh1hKV6Xz8PfXIG+h4lUS0TpGg1xSSPVJBP1DDSPf3uunPvxGw7ETAh3Q2TOdfrgGfj + vZClPFE8Lgml/E+Wua2PME6Yjjn6B/nuBikRAvtXby/5l8VzJO4ZmJ4Zi+/VzmR14I/K + Jp7yXpixHIZQaD/dEn/3IAcmyrxz26sdIkTttXHYJMArDrF+wtI4LvEvSDGQdfZQR+Nb + ePFA== +X-Gm-Message-State: + ALoCoQlJAwJqDOM659hxb/IhQtFnwQA8PpG2kcIKnJ4m61hwLvLRcOYbD9SnDqRn6UZCF+9UxWpm +X-Received: by 10.194.157.68 with SMTP id wk4mr48809924wjb.42.1401258321974; + Tue, 27 May 2014 23:25:21 -0700 (PDT) +Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. + [88.195.111.91]) by mx.google.com with ESMTPSA id + cv4sm40689709wjc.34.2014.05.27.23.25.20 for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 27 May 2014 23:25:21 -0700 (PDT) +From: Jani Nikula +To: David Bremner , Andreas Amann , + notmuch@notmuchmail.org +Subject: Re: notmuch new: emails with BOM are ignored +In-Reply-To: <878upmn6d0.fsf@zancas.localnet> +References: <874n0b4o16.fsf@msstf091.ucc.ie> <878upmn6d0.fsf@zancas.localnet> +User-Agent: Notmuch/0.18~rc0+2~gbc64cdc (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 28 May 2014 09:25:18 +0300 +Message-ID: <87bnuiifn5.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 28 May 2014 06:25:28 -0000 + +On Wed, 28 May 2014, David Bremner wrote: +> I've tagged this as a wishlist bug / feature request for now, until +> somebody has a chance to track down where exactly the issue is, and how +> hard it would be to fix. + +My quick guess is that gmime stops header processing at that point, and +all the headers we require are after that invalid header. Our old header +parser was a bit more relaxed in that sense, and probably just skipped +the header. + +If it were a real email and not spam, I'd be interested... this could be +intentional to trick a spam filter. + + +BR, +Jani. -- 2.26.2