From 5de5a01672604c258ce7fc598393aa11ecee0ddc Mon Sep 17 00:00:00 2001 From: Marcus Brinkmann Date: Thu, 13 Sep 2007 20:42:04 +0000 Subject: [PATCH] 2007-09-13 Marcus Brinkmann * rungpg.c (gpg_new): Handle return value of _gpgme_getenv (fixes small memory leak). --- gpgme/ChangeLog | 5 +++++ gpgme/rungpg.c | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gpgme/ChangeLog b/gpgme/ChangeLog index 4605d67..a496976 100644 --- a/gpgme/ChangeLog +++ b/gpgme/ChangeLog @@ -1,3 +1,8 @@ +2007-09-13 Marcus Brinkmann + + * rungpg.c (gpg_new): Handle return value of _gpgme_getenv (fixes + small memory leak). + 2007-09-07 Marcus Brinkmann * Makefile.am (libgpgme_qt_la_SOURCES): Move diff --git a/gpgme/rungpg.c b/gpgme/rungpg.c index a8fc8ad..70293f8 100644 --- a/gpgme/rungpg.c +++ b/gpgme/rungpg.c @@ -463,6 +463,8 @@ gpg_new (void **engine, const char *file_name, const char *home_dir) goto leave; rc = _gpgme_getenv ("DISPLAY", &dft_display); + if (rc) + goto leave; if (dft_display) { rc = add_arg (gpg, "--display"); @@ -471,8 +473,6 @@ gpg_new (void **engine, const char *file_name, const char *home_dir) free (dft_display); } - if (rc) - goto leave; if (isatty (1)) { @@ -489,7 +489,7 @@ gpg_new (void **engine, const char *file_name, const char *home_dir) if (!rc) { rc = _gpgme_getenv ("TERM", &dft_ttytype); - if (!rc) + if (rc) goto leave; rc = add_arg (gpg, "--ttytype"); -- 2.26.2