From 5be277dece8cd97896c9f00779d0006513c10d3e Mon Sep 17 00:00:00 2001 From: Ezra Peisach Date: Fri, 26 Oct 2001 17:10:33 +0000 Subject: [PATCH] * rcp.exp, rsh_exp (stop_rsh_daemon): Do not close a process and then look for eof. Some versions of expect go through a full timeout in this scenario and others return immediately. New order: kill process, expect eof, close, and then wait. git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@13866 dc483132-0cff-0310-8789-dd5450dbe970 --- src/tests/dejagnu/krb-standalone/ChangeLog | 7 +++++++ src/tests/dejagnu/krb-standalone/rcp.exp | 2 +- src/tests/dejagnu/krb-standalone/rsh.exp | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/tests/dejagnu/krb-standalone/ChangeLog b/src/tests/dejagnu/krb-standalone/ChangeLog index 815bc1083..c8d17c77a 100644 --- a/src/tests/dejagnu/krb-standalone/ChangeLog +++ b/src/tests/dejagnu/krb-standalone/ChangeLog @@ -1,3 +1,10 @@ +2001-10-26 Ezra Peisach + + * rcp.exp, rsh_exp (stop_rsh_daemon): Do not close a process and + then look for eof. Some versions of expect go through a full + timeout in this scenario and others return immediately. New order: + kill process, expect eof, close, and then wait. + 2001-10-25 Ezra Peisach * rsh.exp (rsh_test): Add stop_rsh_daemon before invoking diff --git a/src/tests/dejagnu/krb-standalone/rcp.exp b/src/tests/dejagnu/krb-standalone/rcp.exp index 0c6d4df89..3367b3a29 100644 --- a/src/tests/dejagnu/krb-standalone/rcp.exp +++ b/src/tests/dejagnu/krb-standalone/rcp.exp @@ -72,9 +72,9 @@ proc stop_rsh_daemon { } { global krshd_pid if [info exists krshd_pid] { - catch "close -i $krshd_spawn_id" catch "exec kill $krshd_pid" catch "expect -i $krshd_spawn_id eof" + catch "close -i $krshd_spawn_id" catch "wait -i $krshd_spawn_id" unset krshd_pid } diff --git a/src/tests/dejagnu/krb-standalone/rsh.exp b/src/tests/dejagnu/krb-standalone/rsh.exp index f847f6071..802f5852c 100644 --- a/src/tests/dejagnu/krb-standalone/rsh.exp +++ b/src/tests/dejagnu/krb-standalone/rsh.exp @@ -57,9 +57,9 @@ proc stop_rsh_daemon { } { global krshd_pid if [info exists krshd_pid] { - catch "close -i $krshd_spawn_id" catch "exec kill $krshd_pid" catch "expect -i $krshd_spawn_id eof" + catch "close -i $krshd_spawn_id" catch "wait -i $krshd_spawn_id" unset krshd_pid } -- 2.26.2