From 5b95c182ba37acad56230dfd793c8b1acdfa1767 Mon Sep 17 00:00:00 2001 From: Bartosz Telenczuk Date: Tue, 3 Feb 2015 00:52:41 +0100 Subject: [PATCH] RE: [PATCH] VIM: Automatically refresh folder screen --- bc/8a75095499ff8fe41fea8209c7e973ce4f358b | 74 +++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 bc/8a75095499ff8fe41fea8209c7e973ce4f358b diff --git a/bc/8a75095499ff8fe41fea8209c7e973ce4f358b b/bc/8a75095499ff8fe41fea8209c7e973ce4f358b new file mode 100644 index 000000000..774fa63c1 --- /dev/null +++ b/bc/8a75095499ff8fe41fea8209c7e973ce4f358b @@ -0,0 +1,74 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5CA51431FC7 + for ; Mon, 2 Feb 2015 15:52:47 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id V9D5miiuhRwr for ; + Mon, 2 Feb 2015 15:52:44 -0800 (PST) +Received: from smtp.webfaction.com (mail6.webfaction.com [74.55.86.74]) + by olra.theworths.org (Postfix) with ESMTP id 3794C431FC2 + for ; Mon, 2 Feb 2015 15:52:44 -0800 (PST) +Received: from localhost (87-231-242-54.rev.numericable.fr [87.231.242.54]) + by smtp.webfaction.com (Postfix) with ESMTP id 9F005207DBDF; + Mon, 2 Feb 2015 23:52:43 +0000 (UTC) +Date: Tue, 03 Feb 2015 00:52:41 +0100 +From: Bartosz Telenczuk +To: Franz Fellner , + Bartosz Telenczuk +Message-ID: + <54d00dc9af6cb_47c3ff0b58781fcde@bartels-MacBook-Pro.local.notmuch> +In-Reply-To: <54bff2427d3c1_5b9d145d304d6@TP_L520.notmuch> +References: <1412181367-10906-1-git-send-email-imain@stemwinder.org> + <54bd89e062df1_a663fec9d49e200a3@bts-MacBook-Pro.local.notmuch> + <54bff2427d3c1_5b9d145d304d6@TP_L520.notmuch> +Subject: RE: [PATCH] VIM: Automatically refresh folder screen +Mime-Version: 1.0 +Content-Type: text/plain; + charset=utf-8 +Content-Transfer-Encoding: 7bit +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 02 Feb 2015 23:52:47 -0000 + +Franz Fellner wrote: +> Hi Bartosz, +> +> Great to see one more person interested in notmuch-vim! Hopefully this will make review a little bit easier. +> +> Bartosz Telenczuk wrote: +> > Ian Main wrote: +> > > This patch makes the folder screen refresh each time you 'enter' it. +> > > This way when you read a folder and mark items as read the changes are +> > > reflected immediately when you return to the folder view. +> > +> > That is a good starting point, but why don't we refresh every time we mark an item in the folder screen? +> +> Personally I don't see the benefit. It's a useless call to notmuch for every cursor-move. Especially with the current inefficient implementation. + +I meant that we should refresh after one tags a thread (for example archive it with "A" key). It is slightly annoying that the messages do not disappear after being archived. In my version of the plugin it also causes a wrong thread to be opened when I enter it. + +Anyway, this is a small incremental change that can be implemented later.. It should not hold back the patch. These patches are already great and should accepted as soon as possible, so we can move forward and synchronize notmuch-repo with Ian's repo and possibly catch up with emacs (sic!) client. + +Cheers, + +Bartosz -- 2.26.2