From 5ac09a86624ffe8bdad106e3c75d8692fc170f87 Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Sun, 4 May 2014 08:31:59 +0100 Subject: [PATCH] Re: precedence in `notmuch-search-line-faces' --- 6d/04b9d13265c3c9acf4fdb395efa5503323cae7 | 114 ++++++++++++++++++++++ 1 file changed, 114 insertions(+) create mode 100644 6d/04b9d13265c3c9acf4fdb395efa5503323cae7 diff --git a/6d/04b9d13265c3c9acf4fdb395efa5503323cae7 b/6d/04b9d13265c3c9acf4fdb395efa5503323cae7 new file mode 100644 index 000000000..b70694580 --- /dev/null +++ b/6d/04b9d13265c3c9acf4fdb395efa5503323cae7 @@ -0,0 +1,114 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1F0C9429E37 + for ; Sun, 4 May 2014 00:32:17 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 9deuIncNtZyo for ; + Sun, 4 May 2014 00:32:11 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D9D95431FD6 + for ; Sun, 4 May 2014 00:32:10 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Wgqu0-0000GQ-Ij; Sun, 04 May 2014 08:32:02 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Wgqu0-0007qp-7r; Sun, 04 May 2014 08:32:00 +0100 +From: Mark Walters +To: David Edmondson , notmuch@notmuchmail.org +Subject: Re: precedence in `notmuch-search-line-faces' +In-Reply-To: +References: +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Sun, 04 May 2014 08:31:59 +0100 +Message-ID: <87mwey3spc.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: b6591f8fce483044b55f248c925836e3 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 04 May 2014 07:32:17 -0000 + + +I have a slight preference for making it do the comment (ie reverse the +list). My reason is that we have some other cases such as +notmuch-tag-format that apply the first match, so users might be used to +having the specific first and the more general later. + +It also has a small advantage of being less disruptive but, given that I +don't think any of us realised it changed, I guess most people aren't +using multiple matches. + +Best wishes + +Mark + + + +On Fri, 02 May 2014, David Edmondson wrote: +> The documentation for `notmuch-search-line-faces' says: +> +>> The attributes defined for matching tags are merged, with later +>> attributes overriding earlier. +> +> A comment in `notmuch-search-color-line', which implements this, says: +> +>> ;; Reverse the list so earlier entries take precedence +> +> Clearly these two are at odds. The implementation of +> `notmuch-search-color-line' follows the comment. That is, earlier +> entries in the list take precedence. +> +> The original implementation of `notmuch-search-color-line' followed the +> documentation of the user-visible variable, but this was changed by +> commit 60ebc849 in July 2012. +> +> I'm inclined to go with the documentation and change the implementation, +> but this could obviously ruin things for some users until they reorder +> their settings. +> +> Thoughts? +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2