From 5728e46642ba8731b7b49697739cd2cf14dbe37b Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 10 Mar 2014 13:35:43 +2100 Subject: [PATCH] Re: [PATCH] nmbug: Add 'clone' and replace FETCH_HEAD with @{upstream} --- 06/c0d6d1e0f4d8474bc250239ec37c35dcc84701 | 70 +++++++++++++++++++++++ 1 file changed, 70 insertions(+) create mode 100644 06/c0d6d1e0f4d8474bc250239ec37c35dcc84701 diff --git a/06/c0d6d1e0f4d8474bc250239ec37c35dcc84701 b/06/c0d6d1e0f4d8474bc250239ec37c35dcc84701 new file mode 100644 index 000000000..bf0c426b1 --- /dev/null +++ b/06/c0d6d1e0f4d8474bc250239ec37c35dcc84701 @@ -0,0 +1,70 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 05224431FBD + for ; Sun, 9 Mar 2014 09:35:58 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id wX+RRhT4tU1Q for ; + Sun, 9 Mar 2014 09:35:50 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 117AF431FBC + for ; Sun, 9 Mar 2014 09:35:50 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1WMghX-0005Yr-H4; Sun, 09 Mar 2014 13:35:47 -0300 +Received: (nullmailer pid 1393 invoked by uid 1000); Sun, 09 Mar 2014 + 16:35:44 -0000 +From: David Bremner +To: "W. Trevor King" +Subject: Re: [PATCH] nmbug: Add 'clone' and replace FETCH_HEAD with + @{upstream} +In-Reply-To: <20140308162633.GM16433@odin.tremily.us> +References: + <80db13662a0313711ca3a91e338a63d35e64a83c.1391898002.git.wking@tremily.us> + <87siqsrhch.fsf@zancas.localnet> <20140308162633.GM16433@odin.tremily.us> +User-Agent: Notmuch/0.17+111~g93cd619 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 09 Mar 2014 13:35:43 -0300 +Message-ID: <87siqr8h40.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 09 Mar 2014 16:35:58 -0000 + +"W. Trevor King" writes: +>>=20 +>> I think doing a fetch immediately after a clone deserves a comment. +> +> I commented in the commit message. Basically everything from =E2=80=9COne +> tricky bit is that bare repositories don't set upstream tracking +> branches by default=E2=80=9D down through =E2=80=9Cgives us the master-br= +anch commit.=E2=80=9D +> is describing what's going on here, and why I made these changes. + +Yes. To expand my comment, I think some of that information +should be in the code. + +I'm not really sure about about the alternatives you mention. -- 2.26.2