From 56f61e4b7c17bfe38f9103a2aee272cfca08063b Mon Sep 17 00:00:00 2001 From: Ken Raeburn Date: Thu, 10 Feb 2000 09:31:45 +0000 Subject: [PATCH] * login.c (main): Only destroy xtra_creds if non-null. (Patch from Richard Basch.) git-svn-id: svn://anonsvn.mit.edu/krb5/trunk@12031 dc483132-0cff-0310-8789-dd5450dbe970 --- src/appl/bsd/ChangeLog | 5 +++++ src/appl/bsd/login.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/appl/bsd/ChangeLog b/src/appl/bsd/ChangeLog index e5b56a40a..31bd1b4a0 100644 --- a/src/appl/bsd/ChangeLog +++ b/src/appl/bsd/ChangeLog @@ -1,3 +1,8 @@ +2000-02-10 Ken Raeburn + + * login.c (main): Only destroy xtra_creds if non-null. (Patch + from Richard Basch.) + 2000-02-04 Tom Yu * login.c (main): Reorder some control flow to avoid security hole diff --git a/src/appl/bsd/login.c b/src/appl/bsd/login.c index 237cb4a7d..1832aafb2 100644 --- a/src/appl/bsd/login.c +++ b/src/appl/bsd/login.c @@ -1643,7 +1643,8 @@ int main(argc, argv) com_err(argv[0], retval, "while storing credentials"); } - krb5_cc_destroy(kcontext, xtra_creds); + if (xtra_creds) + krb5_cc_destroy(kcontext, xtra_creds); } else if (forwarded_v5_tickets && rewrite_ccache) { if ((retval = krb5_cc_initialize (kcontext, ccache, me))) { syslog(LOG_ERR, -- 2.26.2