From 568903e8b795eabe8f0283284447c56bfbc93e44 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 24 Nov 2015 08:51:03 +2000 Subject: [PATCH] Re: [PATCH] emacs: poll: return useful errors when poll fails. --- af/f1a47a2c458b95dfc08526947944d712b45009 | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 af/f1a47a2c458b95dfc08526947944d712b45009 diff --git a/af/f1a47a2c458b95dfc08526947944d712b45009 b/af/f1a47a2c458b95dfc08526947944d712b45009 new file mode 100644 index 000000000..0b31fd6e0 --- /dev/null +++ b/af/f1a47a2c458b95dfc08526947944d712b45009 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id CD2D66DE0943 + for ; Mon, 23 Nov 2015 05:02:48 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.313 +X-Spam-Level: +X-Spam-Status: No, score=-0.313 tagged_above=-999 required=5 tests=[AWL=0.238, + RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 0-y9Y66XEHSB for ; + Mon, 23 Nov 2015 05:02:43 -0800 (PST) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 7BE076DE0FFA + for ; Mon, 23 Nov 2015 05:02:43 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1a0qaG-0000UG-2x; Mon, 23 Nov 2015 07:51:04 -0500 +Received: (nullmailer pid 6623 invoked by uid 1000); + Mon, 23 Nov 2015 12:51:03 -0000 +From: David Bremner +To: Mark Walters , notmuch@notmuchmail.org, + ketil@malde.org +Subject: Re: [PATCH] emacs: poll: return useful errors when poll fails. +In-Reply-To: <1446056919-27822-1-git-send-email-markwalters1009@gmail.com> +References: <87bnd5qjnd.fsf@wespe.malde.org> + <1446056919-27822-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 23 Nov 2015 08:51:03 -0400 +Message-ID: <87r3jg516w.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Nov 2015 13:02:49 -0000 + +Mark Walters writes: + +> Previously poll called from emacs would fail silently. This makes it +> return a useful error message. +> +> In the non-deprecated case of notmuch new and appropriate hooks, it +> uses notmuch-call-notmuch-process which gives an error and +> additionally puts the stdout/stderr etc in the *Notmuch errors* +> buffer. +> +> In the deprecated case of a custom poll script it only returns an +> error message. +> +> Commit based on a bug report, and a potential fix, by Ketil Malde. + +applied to release and master + +d -- 2.26.2