From 559455bdee3259683c2d8e3fdd890a7f54266f69 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Thu, 26 Feb 2015 21:04:26 +0200 Subject: [PATCH] Re: [PATCH] lib: make notmuch shared library install_name be full path on Mac OS X --- 72/a7323411d7619d133d8e51db4c78b97fe149c8 | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 72/a7323411d7619d133d8e51db4c78b97fe149c8 diff --git a/72/a7323411d7619d133d8e51db4c78b97fe149c8 b/72/a7323411d7619d133d8e51db4c78b97fe149c8 new file mode 100644 index 000000000..9d4d1ce86 --- /dev/null +++ b/72/a7323411d7619d133d8e51db4c78b97fe149c8 @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id E3FEC431FD7 + for ; Thu, 26 Feb 2015 11:10:43 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 2.438 +X-Spam-Level: ** +X-Spam-Status: No, score=2.438 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ER6HPYt7JDbV for ; + Thu, 26 Feb 2015 11:10:40 -0800 (PST) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 9FCB3431FD2 + for ; Thu, 26 Feb 2015 11:10:40 -0800 (PST) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 296AD10019F; + Thu, 26 Feb 2015 21:04:27 +0200 (EET) +From: Tomi Ollila +To: "J. Lewis Muir" +Subject: Re: [PATCH] lib: make notmuch shared library install_name be full + path on Mac OS X +In-Reply-To: <20150226181423.GA2822@bass.imca.aps.anl.gov> +References: <1409541227-38895-1-git-send-email-jlmuir@imca-cat.org> + <87twyao35q.fsf@maritornes.cs.unb.ca> + <20150226181423.GA2822@bass.imca.aps.anl.gov> +User-Agent: Notmuch/0.19+53~gb45d2f9 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +Cc: notmuch@notmuchmail.org +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 26 Feb 2015 19:10:44 -0000 + +On Thu, Feb 26 2015, "J. Lewis Muir" wrote: + +> On 2/25/15 1:34 AM, David Bremner wrote: +>> Unfortunately we did not receive any feedback from Mac users in the +>> meantime. It would be nice to know that your patch won't break the +>> existing macports and brew packages. I suppose that those work +>> because they install the libraries into a well known location. +> +> Hi, David. +> +> I just tried installing to /usr/local (now on OS X Yosemite 10.10.2), +> and you're right about that; it appears that because it's a standard +> location, it works without my patch. Looking at the dyld(1) man page, +> it says the following for the DYLD_FALLBACK_LIBRARY_PATH environment +> variable (and I think the fact that /usr/local/lib is in the default +> list is the reason why it works without the patch): +> +> This is a colon separated list of directories that contain +> libraries. It is used as the default location for libraries +> not found in their install path. By default, it is set to +> $(HOME)/lib:/usr/local/lib:/lib:/usr/lib. +> +> However, if I install to /opt, it does *not* work without my patch. So, +> I'm still confident that the patch is correct and needed. + +It definitely make sense that when loading "dynamically linked" binary, +and the names of the libraries it tries to open do not contain '/':s (or +perhaps is not absolute), the system attempts to find it from pre-defined +location -- and (possibly) otherwise uses the path coded in the name + +The commit message is just (IMO) somewhat confusing; what is this + + $ otool -L /opt/notmuch-current/lib/libnotmuch.dylib + +is there files /opt/notmuch-current/lib/libnotmuch.dylib and +/opt/notmuch-current/lib/libnotmuch.3.dylib in the fs -- and +what does otool -L opt/notmuch-current/bin/notmuch output + +As a non-mac user it is hard to review this when full visibility +to the file system is not available... + +> +> Regards, +> +> Lewis + + +Tomi + -- 2.26.2