From 55356740f5094e3498dbc6c623076147d5dc51c6 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Fri, 25 Sep 2015 22:17:05 +0300 Subject: [PATCH] Re: [PATCH] test suite: don't consider skipped individual tests as failing --- c9/4858a6b7fb95d411ad90fc8750558af3e5246b | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 c9/4858a6b7fb95d411ad90fc8750558af3e5246b diff --git a/c9/4858a6b7fb95d411ad90fc8750558af3e5246b b/c9/4858a6b7fb95d411ad90fc8750558af3e5246b new file mode 100644 index 000000000..a69c22f93 --- /dev/null +++ b/c9/4858a6b7fb95d411ad90fc8750558af3e5246b @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id C90E26DE0924 + for ; Fri, 25 Sep 2015 12:17:06 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.157 +X-Spam-Level: * +X-Spam-Status: No, score=1.157 tagged_above=-999 required=5 tests=[AWL=-0.239, + SPF_NEUTRAL=0.652, URIBL_SBL=0.644, URIBL_SBL_A=0.1] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id mWBCdIL_EVrE for ; + Fri, 25 Sep 2015 12:17:04 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id 49A056DE02D2 + for ; Fri, 25 Sep 2015 12:17:04 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id AA5CA10008D; + Fri, 25 Sep 2015 22:17:05 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , notmuch@notmuchmail.org +Subject: Re: [PATCH] test suite: don't consider skipped individual tests as + failing +In-Reply-To: <87twqi1y9r.fsf@zancas.localnet> +References: <1443093210-6511-1-git-send-email-david@tethera.net> + <87twqi1y9r.fsf@zancas.localnet> +User-Agent: Notmuch/0.20.2+68~g0c35549 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 25 Sep 2015 19:17:07 -0000 + +On Fri, Sep 25 2015, David Bremner wrote: + +> Tomi Ollila writes: +> +>> +>> Looks OK, but I think there should be (some good) comment here informing +>> any potential viewer that we're not checking $skipped... +>> +> +> I put some vaguely threatening comment in test/README, and a brief +> comment in the file. I've merged the commit, but feel free to send +> suggestions / patches for further doc changes. I more or less made up a +> hypothetical future policy on the spot... + +ack. earlier today I though of make target test-strict -- let's see +whethere I come up something with that... + +> +> d -- 2.26.2