From 5383f99790433d2e887611c20d3f24a4d1ab7867 Mon Sep 17 00:00:00 2001 From: Austin Clements Date: Fri, 20 Jan 2012 14:36:47 +1900 Subject: [PATCH] Re: [PATCH v3 2/2] search: Support automatic tag exclusions --- 42/eea2187060fbe3c71b20d849a497fb06ec531a | 129 ++++++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 42/eea2187060fbe3c71b20d849a497fb06ec531a diff --git a/42/eea2187060fbe3c71b20d849a497fb06ec531a b/42/eea2187060fbe3c71b20d849a497fb06ec531a new file mode 100644 index 000000000..79f03a354 --- /dev/null +++ b/42/eea2187060fbe3c71b20d849a497fb06ec531a @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 1FFFF431FAF + for ; Thu, 19 Jan 2012 11:37:08 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id dsKK1jNLZQBr for ; + Thu, 19 Jan 2012 11:37:07 -0800 (PST) +Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU + [18.7.68.35]) + by olra.theworths.org (Postfix) with ESMTP id 9A188431FAE + for ; Thu, 19 Jan 2012 11:37:07 -0800 (PST) +X-AuditID: 12074423-b7f9c6d0000008c3-3c-4f1870e3cb02 +Received: from mailhub-auth-3.mit.edu ( [18.9.21.43]) + by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP + id FF.C6.02243.3E0781F4; Thu, 19 Jan 2012 14:37:07 -0500 (EST) +Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) + by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q0JJb6rp027124; + Thu, 19 Jan 2012 14:37:06 -0500 +Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91]) + (authenticated bits=0) + (User authenticated as amdragon@ATHENA.MIT.EDU) + by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0JJb5qk011923 + (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); + Thu, 19 Jan 2012 14:37:06 -0500 (EST) +Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77) + (envelope-from ) + id 1Rnxmx-00044E-W6; Thu, 19 Jan 2012 14:36:48 -0500 +Date: Thu, 19 Jan 2012 14:36:47 -0500 +From: Austin Clements +To: Pieter Praet +Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions +Message-ID: <20120119193647.GN16740@mit.edu> +References: <1326586654-16840-3-git-send-email-amdragon@mit.edu> + <1327000744-25463-1-git-send-email-pieter@praet.org> +MIME-Version: 1.0 +Content-Type: text/plain; charset=us-ascii +Content-Disposition: inline +In-Reply-To: <1327000744-25463-1-git-send-email-pieter@praet.org> +User-Agent: Mutt/1.5.21 (2010-09-15) +X-Brightmail-Tracker: + H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hTV1n1cIOFvcHUSu8X1mzOZLX6/vsHs + wOTxbNUtZo+OfZdZA5iiuGxSUnMyy1KL9O0SuDLWn2ljL/jBV3H6wBXWBsYX3F2MnBwSAiYS + 6/8eZYWwxSQu3FvP1sXIxSEksI9R4sfzqSwQzgZGia3975khnJNMEvvn/meEcJYwSjTdecoC + 0s8ioCpx/+1ZdhCbTUBDYtv+5YwgtoiAssTpJz/B4swCWhJbN34AiwsLuEjs3tYEZvMK6Eh0 + rz0BViMkUC5x8tMJZoi4oMTJmU9YYHpv/HvJ1MXIAWRLSyz/xwFicgo4SnR99wSpEBVQkZhy + chvbBEahWUiaZyFpnoXQvICReRWjbEpulW5uYmZOcWqybnFyYl5eapGumV5uZoleakrpJkZQ + WLO7KO9g/HNQ6RCjAAejEg8vp6uEvxBrYllxZe4hRkkOJiVR3rh8oBBfUn5KZUZicUZ8UWlO + avEhRgkOZiUR3nk5QDnelMTKqtSifJiUNAeLkjivhtY7PyGB9MSS1OzU1ILUIpisDAeHkgRv + PDB+hQSLUtNTK9Iyc0oQ0kwcnCDDeYCGR4HU8BYXJOYWZ6ZD5E8xKkqJ84aCJARAEhmleXC9 + sLTzilEc6BVhXk+QKh5gyoLrfgU0mAlosEeTGMjgkkSElFQD48mWqg07b8gGPd7+N2TNIYWH + bq1xjy3sgg1WRduI2yYtmHVyXlDDxbWH89t95Rt/7o1KmOq0xN1I/G/QJEmHeeH5Zn+C+1Jz + f0zfee9L4LuIwr1LrfKv9K9052T0yZn8Yb49e9++iQrRfzw72hWSpok0si67dXH/q4K9hbJv + juwU1mlmWaAmosRSnJFoqMVcVJwIAHD+VYwWAwAA +Cc: Notmuch Mail +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Thu, 19 Jan 2012 19:37:08 -0000 + +Quoth Pieter Praet on Jan 19 at 8:19 pm: +> Nice feature! I won't be using it myself, but I can imagine it being +> *very* useful for those who still feel the need to "delete" email :). + +Same here. I probably will use the spam tag, though. + +> Nitpicking: +> +> - All other config-related functions and args include the section title +> in their name [1], so for the sake of consistency, we might want to +> mirror that. Also, the "auto"matic part is pretty much a given. +> +> So I'd like to suggest replacing all occurences of "auto_exclude_tags" +> with "search_exclude_tags" (and simply "exclude_tags" in the args to +> `_config_get_list' and `_config_set_list', of course). + +You are technically correct, the best kind of correct. I'd completely +missed this pattern. This should get fixed ASAP, while this feature +still has limited adoption. + +> Unfortunately, this would also partially invalidate your recent NEWS +> submission [2]. + +No worries, though maybe you want to tack an updated version of that +patch on the end of your series? + +> - If the 'search.exclude_tags' option is missing from the config file, +> its value is automatically set to "deleted;spam;", which probably isn't +> a sane default. Luckily, you've already provided the solution [3]. + +I'm good either way. I got lost in the discussion of defaults but +Jamie assured me everything was okay, so I took the path of least +resistance and left things as they were. + +> - To make new users aware of the config option's existence, we should +> prompt them to configure it during setup. + +Sure. + +> Patches follow. +> +> +> Peace +> +> +> [1] Eg. `notmuch_config_get_user_name', `notmuch_config_get_new_tags', +> `notmuch_config_get_maildir_synchronize_flags', ... +> +> [2] id:"1326920330-31496-1-git-send-email-amdragon@mit.edu" +> +> [3] id:"20120117203211.GQ16740@mit.edu" +> -- 2.26.2