From 5354b788691f6c466325937794764e14abb421f9 Mon Sep 17 00:00:00 2001 From: Antoine Musso Date: Mon, 12 Nov 2012 16:47:40 +0100 Subject: [PATCH] Fix callback calling when using from a parent directory Authors might want to use a shared reveal.js installation for all their presentations such as: $ ls -1 -F 20120105-how-to-use-git.html 20121101-wikimedia-scaling.html reveal.js/ $ In this case, the plugin callbacks will not be called at all. When using head.js, the callback is marked as depending upon the loading of a Javscript filename. The regex used to find out the filename is applied to the full path which in the above case would be something like: reveal.js/plugin/highlight/highlight.js The regex will thus give out 'reveal.js' as a file depency instead of the expected 'highlight.js' The fix is quiet easy: simply make sure that we are looking for a file that actually ends with '.js' instead of simply containing '.js' by adding a $. --- js/reveal.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/js/reveal.js b/js/reveal.js index 1c4f235..be1292d 100644 --- a/js/reveal.js +++ b/js/reveal.js @@ -232,7 +232,7 @@ var Reveal = (function(){ // Extension may contain callback functions if( typeof s.callback === 'function' ) { - head.ready( s.src.match( /([\w\d_\-]*)\.?js|[^\\\/]*$/i )[0], s.callback ); + head.ready( s.src.match( /([\w\d_\-]*)\.?js$|[^\\\/]*$/i )[0], s.callback ); } } } -- 2.26.2