From 5264629f55e35bbff227c71404ef9bbc0b793f9b Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Fri, 28 Aug 2015 21:22:29 +0300 Subject: [PATCH] Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by default with --client --- 13/0918fb360260c4a960cfad37642160fd69784a | 238 ++++++++++++++++++++++ 1 file changed, 238 insertions(+) create mode 100644 13/0918fb360260c4a960cfad37642160fd69784a diff --git a/13/0918fb360260c4a960cfad37642160fd69784a b/13/0918fb360260c4a960cfad37642160fd69784a new file mode 100644 index 000000000..bb8c33509 --- /dev/null +++ b/13/0918fb360260c4a960cfad37642160fd69784a @@ -0,0 +1,238 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9F66E6DE0AF8 + for ; Fri, 28 Aug 2015 11:22:35 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.296 +X-Spam-Level: +X-Spam-Status: No, score=-0.296 tagged_above=-999 required=5 tests=[AWL=0.424, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id PtTBGu0Ci5Gy for ; + Fri, 28 Aug 2015 11:22:33 -0700 (PDT) +Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com + [209.85.212.177]) + by arlo.cworth.org (Postfix) with ESMTPS id 4E8676DE005F + for ; Fri, 28 Aug 2015 11:22:33 -0700 (PDT) +Received: by wicfv10 with SMTP id fv10so19246010wic.0 + for ; Fri, 28 Aug 2015 11:22:31 -0700 (PDT) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:cc:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=WMQTSKtAXpvzr4+UBJ1BO0gf8S7dw2fK+iiK9fGBElw=; + b=h27mpvL1YsvFcAOFW1Lzkws42Ori3brS2nFFW5JZyJZEn+USIHDVIE/TkIVe015Coq + 37ea2w6aZ3B1k1WO/rjLyF378ym0ctUI4g+ZBSicHNdQSr1IoRnQFUg3QieonXTlff70 + qaXwAhzZL7CKHFHvFogZUUpZ96EAGhfMBEa1q4UKg8P8O7gOfmojmTfYr60YHfgLhDBB + UAoJYxRXH0xWFYuTGdjLGDc3B9aQPg8TW+paKTLvTsnFuHmV2FciigfKjVm5JimMF+kH + v4okaHbueGhyT+i7AIFBz5US3XvOfrFYryfj82ZAIf/1zzo0UVJ824MC/E90PEK3j7Hi + x0yg== +X-Gm-Message-State: + ALoCoQmagIm60FgX0znythkZhfbBaos51pbWGBeoMvti9GnGAnUF5VYCPs+U1N0uhtesD/urelOc +X-Received: by 10.180.91.14 with SMTP id ca14mr6126367wib.5.1440786151486; + Fri, 28 Aug 2015 11:22:31 -0700 (PDT) +Received: from localhost (mobile-access-bcee4f-131.dhcp.inet.fi. + [188.238.79.131]) + by smtp.gmail.com with ESMTPSA id fs8sm4926800wib.0.2015.08.28.11.22.30 + (version=TLSv1/SSLv3 cipher=OTHER); + Fri, 28 Aug 2015 11:22:30 -0700 (PDT) +From: Jani Nikula +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 5/5] notmuch-emacs-mua: do not create a frame by + default with --client +In-Reply-To: +References: + <455026447d3f75b1038ac11cebe734431604be9d.1439629384.git.jani@nikula.org> + +User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 28 Aug 2015 21:22:29 +0300 +Message-ID: <87si73uvbu.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 28 Aug 2015 18:22:35 -0000 + +On Wed, 26 Aug 2015, Tomi Ollila wrote: +> On Sat, Aug 15 2015, Jani Nikula wrote: +> +>> Make the default behaviour for --client the same as emacsclient +>> default: do not create a new frame. Add a new option --create-frame, +>> passing the same option to emacsclient to create a frame. +>> +>> --- +>> +>> v2: fix killing frame with --create-frame +>> +>> v3: fix --create-frame w/o --client parameter check +>> +>> v4: fix kill terminal logic, document behaviour with daemon mode +>> --- +>> doc/man1/notmuch-emacs-mua.rst | 6 ++++++ +>> notmuch-emacs-mua | 14 ++++++++++---- +>> 2 files changed, 16 insertions(+), 4 deletions(-) +>> +>> diff --git a/doc/man1/notmuch-emacs-mua.rst b/doc/man1/notmuch-emacs-mua.rst +>> index 89a2fead17b1..c3689eb82c8a 100644 +>> --- a/doc/man1/notmuch-emacs-mua.rst +>> +++ b/doc/man1/notmuch-emacs-mua.rst +>> @@ -45,6 +45,12 @@ Supported options for **notmuch-emacs-mua** include +>> Automatically start Emacs in daemon mode, if the Emacs server +>> is not running. Applicable with ``--client``. +>> +>> + ``--create-frame`` +>> + Create a new frame instead of trying to use the current Emacs +>> + frame. Applicable with ``--client``. This will be required +>> + when Emacs is running (or automatically started with +>> + ``--auto-daemon``) in daemon mode. +>> + +>> ``--print`` +>> Output the resulting elisp to stdout instead of evaluating it. +>> +>> diff --git a/notmuch-emacs-mua b/notmuch-emacs-mua +>> index ac03a4a60d56..b51d8d0e2c5b 100755 +>> --- a/notmuch-emacs-mua +>> +++ b/notmuch-emacs-mua +>> @@ -37,11 +37,10 @@ PRINT_ONLY= +>> NO_WINDOW= +>> USE_EMACSCLIENT= +>> AUTO_DAEMON= +>> -CREATE_FRAME="-c" +>> +CREATE_FRAME= +>> +>> # The crux of it all: construct an elisp progn and eval it. +>> ELISP="(prog1 'done (require 'notmuch) (notmuch-mua-new-mail)" +>> -ELISP="${ELISP} (setq message-exit-actions (list #'save-buffers-kill-terminal))" +>> +>> # Short options compatible with mutt(1). +>> while getopts :s:c:b:i:h opt; do +>> @@ -65,7 +64,7 @@ while getopts :s:c:b:i:h opt; do +>> opt=${opt%%=*} +>> ;; +>> # Long options without arguments. +>> - --help|--print|--no-window-system|--client|--auto-daemon) +>> + --help|--print|--no-window-system|--client|--auto-daemon|--create-frame) +>> ;; +>> *) +>> echo "$0: unknown long option ${opt}, or argument mismatch." >&2 +>> @@ -103,7 +102,6 @@ while getopts :s:c:b:i:h opt; do +>> ;; +>> --no-window-system) +>> NO_WINDOW="-nw" +>> - CREATE_FRAME= +>> ;; +>> --client) +>> USE_EMACSCLIENT="yes" +>> @@ -111,6 +109,9 @@ while getopts :s:c:b:i:h opt; do +>> --auto-daemon) +>> AUTO_DAEMON="--alternate-editor=" +>> ;; +>> + --create-frame) +>> + CREATE_FRAME="-c" +>> + ;; +>> *) +>> # We should never end up here. +>> echo "$0: internal error (option ${opt})." >&2 +> +> This looks pretty good now; I player quite a bit with --client, +> --create-frame and --auto-daemon +> (with and without setting EMACSCLIENT='echo emacsclient') +> +> Based on that I think this check should be added here (after option +> parsing): +> +> if [ -n "$AUTO_DAEMON" -a -z "$CREATE_FRAME" ]; then +> echo "$0: --auto-daemon is only applicable with --create-frame." >&2 +> exit 1 +> fi +> +> without this one may execute ./notmuch-emacs-mua --client --auto-daemon +> which yields starting emacs in daemon mode (in this example it is expected +> emacs is not running; otherwise --auto-daemon has no use in this example) +> -- but no ui to that newly-running emacs is provided. Similar behaviour +> can be observed by the following + +This problem is present with the current code already, right now. I +don't see the need to fix everything in my series. + +> $ emacsclient --eval '(kill emacs) ;; but beware! ' +> $ emacsclient --alternate-editor= --eval '(find-file "/etc/passwd")' +> +> (side note: using this --alternate-editor= is pretty nifty way to get it done) +> +> emacs --daemon is executed which loaded /etc/passwd but w/o ui +> +> Note the difference in: +> +> emacsclient --alternate-editor= /etc/passwd +> +> now emacs --daemon is executed *and* ui where /etc/passwd is available is +> provided! +> +> otoh, +> emacsclient --alternate-editor= -c [-nw] --eval '(find-file "/etc/passwd")' +> +> works fine, albeit a bit different than the one where /etc/passwd was given +> as a simple filename argument. +> +> comparative to ./notmuch-emacs-mua --client --create-frame --auto-daemon +> +>> @@ -128,6 +129,11 @@ for arg; do +>> ELISP="${ELISP} (message-goto-to) (insert \"${arg}, \")" +>> done +>> +>> +# Kill the terminal/frame if we're creating one. +>> +if [ -z "$USE_EMACSCLIENT" -o -n "$CREATE_FRAME" -o -n "$NO_WINDOW" ]; then +>> + ELISP="${ELISP} (setq message-exit-actions (list #'save-buffers-kill-terminal))" +>> +fi +> +> I am not very happy that message-exit-actions was added to $ELISP when +> not using emacsclient; when emacs is started its sole (initial) purpose is +> to serve mail sending (and not lending a frame in some other emacs) -- in +> this case it would be nice to be able to retrieve the sent mail buffer. + +And I am not very happy with being expected to modify these patches ad +infinitum while trying to get back the *one* use case I wrote this +script for in the first place, and that got broken somewhere down the +line. + +Sincerely, +Jani. + + +> +> perhaps the above could be changed to just +> +> if [ -n "$CREATE_FRAME" ]; then +> ELISP="${ELISP} (setq message-exit-actions (list #'save-buffers-kill-terminal))" +> fi +> +> another option is --yet-another-option ;/ +> +> No other issues (relevant to this series). +> +> Tomi +> +> +>> + +>> # End progn. +>> ELISP="${ELISP})" +>> +>> -- +>> 2.1.4 -- 2.26.2