From 50910b319b0c2d35864438509c747126b448ffbc Mon Sep 17 00:00:00 2001 From: David Bremner Date: Mon, 27 Jun 2016 15:49:27 +0200 Subject: [PATCH] Re: [PATCH v2] test: add "set -u" to test-lib.sh --- ab/efd66e5db0562800188a403664141bd5bcc2ae | 71 +++++++++++++++++++++++ 1 file changed, 71 insertions(+) create mode 100644 ab/efd66e5db0562800188a403664141bd5bcc2ae diff --git a/ab/efd66e5db0562800188a403664141bd5bcc2ae b/ab/efd66e5db0562800188a403664141bd5bcc2ae new file mode 100644 index 000000000..5c752183d --- /dev/null +++ b/ab/efd66e5db0562800188a403664141bd5bcc2ae @@ -0,0 +1,71 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id BEE466DE0261 + for ; Mon, 27 Jun 2016 06:49:42 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.011 +X-Spam-Level: +X-Spam-Status: No, score=-0.011 tagged_above=-999 required=5 tests=[AWL=0.000, + SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id RBWNTlPlas7U for ; + Mon, 27 Jun 2016 06:49:35 -0700 (PDT) +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id CF7876DE0243 + for ; Mon, 27 Jun 2016 06:49:34 -0700 (PDT) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1bHWuY-0001YS-Sd; Mon, 27 Jun 2016 09:49:14 -0400 +Received: (nullmailer pid 24225 invoked by uid 1000); + Mon, 27 Jun 2016 13:49:27 -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Cc: tomi.ollila@iki.fi +Subject: Re: [PATCH v2] test: add "set -u" to test-lib.sh +In-Reply-To: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi> +References: <1465336777-31225-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.22+51~gcc1a6d2 (https://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 27 Jun 2016 15:49:27 +0200 +Message-ID: <87a8i64u8o.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 27 Jun 2016 13:49:42 -0000 + +Tomi Ollila writes: + +> This prohibits unset variables to expand to empty strings. +> Without this e.g misspelled variables cause unintentional results. +> +> Now all the test variables are either initialized, or in case of +> optional arguments and user-provided environment variables (i.e. +> when it is not know whethet the variable is set) the form +> ${variable-} is used. +> +> Two unusable lines (leftovers?) in T360-symbol-hiding.sh were removed; +> this was the only non-lib test code that needed to be edited for this +> change to work. + +Hi Tomi; + +I like the idea, but currently I get many test failures with + +/test-lib.sh: line 926: test_subtest_missing_external_prereq_: unbound variable + +d -- 2.26.2