From 4eb2da8fca6746ef76b4ace73625c9419709c3f5 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 15 Sep 2013 10:32:24 +0300 Subject: [PATCH] Re: [PATCH] emacs: bugfix unquoted symbol --- ca/659599986fd88c52cc04dc6c0fc64365c2f349 | 98 +++++++++++++++++++++++ 1 file changed, 98 insertions(+) create mode 100644 ca/659599986fd88c52cc04dc6c0fc64365c2f349 diff --git a/ca/659599986fd88c52cc04dc6c0fc64365c2f349 b/ca/659599986fd88c52cc04dc6c0fc64365c2f349 new file mode 100644 index 000000000..d3e347a5f --- /dev/null +++ b/ca/659599986fd88c52cc04dc6c0fc64365c2f349 @@ -0,0 +1,98 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 244D3431FAF + for ; Sun, 15 Sep 2013 00:32:39 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kUi2rATS7JUO for ; + Sun, 15 Sep 2013 00:32:31 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 5DCBB431FAE + for ; Sun, 15 Sep 2013 00:32:31 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 2EEDB1000B2; + Sun, 15 Sep 2013 10:32:25 +0300 (EEST) +From: Tomi Ollila +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH] emacs: bugfix unquoted symbol +In-Reply-To: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com> +References: <1379189827-21363-1-git-send-email-markwalters1009@gmail.com> +User-Agent: Notmuch/0.16+77~g2561895 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 15 Sep 2013 07:32:39 -0000 + +On Sat, Sep 14 2013, Mark Walters wrote: + +> In the recent changes for search order handling the default-value of +> notmuch-search-oldest-first was used. However, default-value needs a +> symbol so the symbol-name needs to be quoted. +> +> This missing quote was causing strange sort-orders in some cases. +> --- +> +> I think this is clearly correct (and what was intended) and it seems +> to work as expected. + +Marked ready. + +> +> Best wishes +> +> Mark +> + +Tomi + +> +> +> +> emacs/notmuch.el | 2 +- +> 1 files changed, 1 insertions(+), 1 deletions(-) +> +> diff --git a/emacs/notmuch.el b/emacs/notmuch.el +> index 4de6229..0ff248b 100644 +> --- a/emacs/notmuch.el +> +++ b/emacs/notmuch.el +> @@ -888,7 +888,7 @@ the configured default sort order." +> nil +> ;; Use the default search order (if we're doing a search from a +> ;; search buffer, ignore any buffer-local overrides) +> - (default-value notmuch-search-oldest-first))) +> + (default-value 'notmuch-search-oldest-first))) +> +> (let* ((query (or query (notmuch-read-query "Notmuch search: "))) +> (buffer (get-buffer-create (notmuch-search-buffer-title query)))) +> -- +> 1.7.9.1 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2