From 4e5cd07e5c5c350342268f25255974e9dcbf151f Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Sun, 10 Aug 2014 22:49:45 +0300 Subject: [PATCH] Re: [PATCH 0/2] Improve message threading --- 40/037ae6194ccc0700053523e7fdde48165adfac | 92 +++++++++++++++++++++++ 1 file changed, 92 insertions(+) create mode 100644 40/037ae6194ccc0700053523e7fdde48165adfac diff --git a/40/037ae6194ccc0700053523e7fdde48165adfac b/40/037ae6194ccc0700053523e7fdde48165adfac new file mode 100644 index 000000000..fe7e2093c --- /dev/null +++ b/40/037ae6194ccc0700053523e7fdde48165adfac @@ -0,0 +1,92 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id F2FF0431FAF + for ; Sun, 10 Aug 2014 12:50:11 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id 7+UhkrC2xbnQ for ; + Sun, 10 Aug 2014 12:50:02 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id 7DB71431FAE + for ; Sun, 10 Aug 2014 12:50:02 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 30459100033; + Sun, 10 Aug 2014 22:49:46 +0300 (EEST) +From: Tomi Ollila +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH 0/2] Improve message threading +In-Reply-To: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz> +References: <1401113157-32454-1-git-send-email-sojkam1@fel.cvut.cz> +User-Agent: Notmuch/0.18.1+25~gdaf4b6f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 10 Aug 2014 19:50:12 -0000 + +On Mon, May 26 2014, Michal Sojka wrote: + +> Hi all, +> +> I noticed that in certain situations notmuch does not reconstruct +> thread structure correctly. The fix was quite trivial - see the +> patches. +> +> The patch fixes my problem, however, as I learnt from the thread +> around id:87oazwjq1e.fsf@yoom.home.cworth.org, there are more problems +> in this code. I think that my problem is orthogonal to what was +> discussed there. +> +> The patch does not break any existing text (except two in +> T460-emacs-tree.sh, which fail even with 0.18 on my system). +> +> Cheers, +> -Michal + +This series looks good to me, and patch 2/2 fixes the borken test +introduced in patch 1/2 -- i.e. the fix is clear, test is somewhat +tedious to be parsed by a human ;D + +Tomi + + +> +> Michal Sojka (2): +> Add test for incorrect threading of messages +> Make parsing of References and In-Reply-To header less error prone +> +> lib/database.cc | 15 ++++++--------- +> test/T510-thread-replies.sh | 27 +++++++++++++++++++++++++++ +> 2 files changed, 33 insertions(+), 9 deletions(-) +> +> -- +> 2.0.0.rc2 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> http://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2