From 4e340125dcc667f23bb069cf739ba4ba7d05c4c5 Mon Sep 17 00:00:00 2001 From: Aaron Ecay Date: Sun, 11 May 2014 17:04:42 +2000 Subject: [PATCH] Re: [PATCH v2] emacs: Add support for saved search accelerators --- 7b/7c54ca16b9d603ae833e89c8e17b21796d762b | 103 ++++++++++++++++++++++ 1 file changed, 103 insertions(+) create mode 100644 7b/7c54ca16b9d603ae833e89c8e17b21796d762b diff --git a/7b/7c54ca16b9d603ae833e89c8e17b21796d762b b/7b/7c54ca16b9d603ae833e89c8e17b21796d762b new file mode 100644 index 000000000..b0883fb5f --- /dev/null +++ b/7b/7c54ca16b9d603ae833e89c8e17b21796d762b @@ -0,0 +1,103 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 5FCB6431FC0 + for ; Sat, 10 May 2014 14:04:26 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.799 +X-Spam-Level: +X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 + tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, + FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id LAnLWbJrQuqb for ; + Sat, 10 May 2014 14:04:20 -0700 (PDT) +Received: from mail-qc0-f180.google.com (mail-qc0-f180.google.com + [209.85.216.180]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 17D5F431FBF + for ; Sat, 10 May 2014 14:04:20 -0700 (PDT) +Received: by mail-qc0-f180.google.com with SMTP id i17so6049850qcy.25 + for ; Sat, 10 May 2014 14:04:19 -0700 (PDT) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; + h=from:to:subject:in-reply-to:message-id:references:user-agent + :mail-followup-to:date:mime-version:content-type + :content-transfer-encoding; + bh=//0xM99fQZIOUloFocnsmFYpoyVvzLGABqQnr/s/0ok=; + b=cecrDjzkDIHGhTZYp7mtPDfuMp0Whxmmq2lnUspEL7tuEutptksnM+xv3WdoSWpHqo + o3EVwTE6+gvU6CTK0DwT1g8920QfKYbkB8wA0ncgLwb3NCEDAKGKyieW0TYBm7okNL0e + ShzfAPbw+pAZprr8CUsg4TbWRvHe1T0m2vl8vvKo74eVGlvFjfKnqhEJUHBwYg5AjTtx + VZf3MbJ7dNOQjMQwqmQpDnKlE7Drbe68/a/56+2YFZ3U9kzZqAUWO2quZQRPbSnstj3E + c+jI6q7fDom4gxm2dx25gYSJLmjyT4shc4j/nOKfYBFvXZjfWVOOLwhLEnJxd60h/VA1 + 4sUw== +X-Received: by 10.224.147.208 with SMTP id m16mr25651897qav.13.1399755859412; + Sat, 10 May 2014 14:04:19 -0700 (PDT) +Received: from localhost (c-68-81-204-26.hsd1.pa.comcast.net. [68.81.204.26]) + by mx.google.com with ESMTPSA id j5sm41625qai.34.2014.05.10.14.04.18 + for + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 10 May 2014 14:04:18 -0700 (PDT) +From: Aaron Ecay +To: Mark Walters , David Edmondson , + notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Add support for saved search accelerators +In-Reply-To: <87zjislji0.fsf@qmul.ac.uk> +Message-ID: <87oaz5uzco.fsf@gmail.com> +References: <1399385776-19918-1-git-send-email-dme@dme.org> + <1399461694-25350-1-git-send-email-dme@dme.org> + <1399461694-25350-2-git-send-email-dme@dme.org> + <87zjislji0.fsf@qmul.ac.uk> +User-Agent: Notmuch/0.17+160~g03680d1 (http://notmuchmail.org) Emacs/24.4.50.2 + (x86_64-unknown-linux-gnu) +Mail-Followup-To: Mark Walters , David Edmondson + , notmuch@notmuchmail.org +Date: Sat, 10 May 2014 17:04:42 -0400 +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 10 May 2014 21:04:26 -0000 + +Hello, + +2014ko maiatzak 8an, Mark Walters-ek idatzi zuen: +> +> Hi +> +> This version looks good to me. +> +> The only slight query I have is which key to bind it to: Austin used g +> in notmuch-go and this uses j. Austin said on irc that he chose g +> because it wasn't bound and matched gmail's shortcut. +> +> Personally I like j (as it starts fewer words than g) and given that we +> don't match any of gmail's other bindings I don't think there is much +> advantage to doing so in this case. + +All other things being equal, I=E2=80=99d prefer =E2=80=9Cj=E2=80=9D here, = +but for different +reasons. =E2=80=9Cg=E2=80=9D is the emacs-standard key to refresh or rever= +t a buffer. +In my personal customization file I bound =E2=80=9Cg=E2=80=9D to +notmuch-refresh-this-buffer in notmuch-(show/search)-mode-map long ago +(and forgot this binding was not standard until reading above that g is +not bound). It=E2=80=99s probably better emacs citizenship to not use such= + a +standard key for a different purpose. + +-- +Aaron Ecay -- 2.26.2