From 4e1806ef7c002a4a333c5822c13d7ceca303bf70 Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 8 Apr 2012 14:12:02 -0400 Subject: [PATCH] save whole form state, not just QUERY_STRING, for postsignin Normally, needsignin is called when there is a QUERY_STRING, not when a form is posted. However, it's certianly possible, and should be supported, to make a form that invokes an ikiwiki action that checks needsignin. I encountered this when posting ?do=rename&page=foo. The form is displayed without checking needsignin, for complicated reasons. Posting the form is when the true authentication happens. --- IkiWiki/CGI.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/IkiWiki/CGI.pm b/IkiWiki/CGI.pm index 62383b6fd..5baa6c179 100644 --- a/IkiWiki/CGI.pm +++ b/IkiWiki/CGI.pm @@ -131,7 +131,7 @@ sub needsignin ($$) { if (! defined $session->param("name") || ! userinfo_get($session->param("name"), "regdate")) { - $session->param(postsignin => $ENV{QUERY_STRING}); + $session->param(postsignin => $q->query_string); cgi_signin($q, $session); cgi_savesession($session); exit; -- 2.26.2