From 4dc3291199055c076b89267c8bf2bdb366c6e635 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sun, 1 Oct 2017 23:53:20 +0300 Subject: [PATCH] cli: change while to for in keyword argument processing Using a for loop makes it easier to use continue, in preparation for future changes. No functional changes. --- command-line-arguments.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/command-line-arguments.c b/command-line-arguments.c index ee8be189..c591dcbe 100644 --- a/command-line-arguments.c +++ b/command-line-arguments.c @@ -13,14 +13,14 @@ static notmuch_bool_t _process_keyword_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_str) { - const notmuch_keyword_t *keywords = arg_desc->keywords; + const notmuch_keyword_t *keywords; if (next == '\0') { /* No keyword given */ arg_str = ""; } - while (keywords->name) { + for (keywords = arg_desc->keywords; keywords->name; keywords++) { if (strcmp (arg_str, keywords->name) == 0) { if (arg_desc->opt_flags) *arg_desc->opt_flags |= keywords->value; @@ -28,7 +28,6 @@ _process_keyword_arg (const notmuch_opt_desc_t *arg_desc, char next, const char *arg_desc->opt_keyword = keywords->value; return TRUE; } - keywords++; } if (next != '\0') fprintf (stderr, "Unknown keyword argument \"%s\" for option \"%s\".\n", arg_str, arg_desc->name); -- 2.26.2