From 4bf78074db634016bc8fb291923a331cdaa0e89d Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Mon, 16 Jan 2012 09:12:38 +0000 Subject: [PATCH] Re: [PATCH v2 3/3] search: Support automatic tag exclusions --- d5/da9c9d0f8a6fec03fc448b2fe7ee78431a80fa | 99 +++++++++++++++++++++++ 1 file changed, 99 insertions(+) create mode 100644 d5/da9c9d0f8a6fec03fc448b2fe7ee78431a80fa diff --git a/d5/da9c9d0f8a6fec03fc448b2fe7ee78431a80fa b/d5/da9c9d0f8a6fec03fc448b2fe7ee78431a80fa new file mode 100644 index 000000000..3e5e642c7 --- /dev/null +++ b/d5/da9c9d0f8a6fec03fc448b2fe7ee78431a80fa @@ -0,0 +1,99 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BD74F431E62 + for ; Mon, 16 Jan 2012 01:14:01 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: -0.7 +X-Spam-Level: +X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 + tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id A-vJgu8vxJzv for ; + Mon, 16 Jan 2012 01:14:01 -0800 (PST) +Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com + [209.85.212.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id F2B16431FC0 + for ; Mon, 16 Jan 2012 01:14:00 -0800 (PST) +Received: by wibhr12 with SMTP id hr12so2198004wib.26 + for ; Mon, 16 Jan 2012 01:13:59 -0800 (PST) +Received: by 10.180.85.4 with SMTP id d4mr17933375wiz.0.1326705239921; + Mon, 16 Jan 2012 01:13:59 -0800 (PST) +Received: from hotblack-desiato.hh.sledj.net + (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25]) + by mx.google.com with ESMTPS id ej7sm21431762wbb.20.2012.01.16.01.13.58 + (version=TLSv1/SSLv3 cipher=OTHER); + Mon, 16 Jan 2012 01:13:58 -0800 (PST) +Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000) + id A74949FD88; Mon, 16 Jan 2012 09:12:38 +0000 (GMT) +To: Jameson Graef Rollins , + Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions +In-Reply-To: <87wr8tsvit.fsf@servo.finestructure.net> +References: <1326258173-21163-1-git-send-email-amdragon@mit.edu> + <1326496024-14403-1-git-send-email-amdragon@mit.edu> + <1326496024-14403-4-git-send-email-amdragon@mit.edu> + <87wr8tsvit.fsf@servo.finestructure.net> +User-Agent: Notmuch/0.10.2+186~gd0f7804 (http://notmuchmail.org) + Emacs/24.0.92.1 (x86_64-pc-linux-gnu) +From: David Edmondson +Date: Mon, 16 Jan 2012 09:12:38 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: multipart/signed; boundary="=-=-="; + micalg=pgp-sha1; protocol="application/pgp-signature" +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 16 Jan 2012 09:14:01 -0000 + +--=-=-= +Content-Type: text/plain +Content-Transfer-Encoding: quoted-printable + +On Sat, 14 Jan 2012 15:40:26 -0800, Jameson Graef Rollins wrote: +> This patch looks fine. Philosophical UI discussion to follow: +>=20 +> On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements wr= +ote: +> > + if (notmuch_config_get_auto_exclude_tags (config, &tmp) =3D=3D NUL= +L) { +> > + const char *tags[] =3D { "deleted", "spam" }; +> > + notmuch_config_set_auto_exclude_tags (config, tags, 2); +> > + } +>=20 +> This creates the config section with the exclude list pre-set to +> "deleted;spam". + +I don't think that anything should be excluded from the search results +by default, at least not as a default behaviour of the 'notmuch' +binary. + +Having "deleted" and "spam" as default settings in the configuration +file might be more reasonable. + +--=-=-= +Content-Type: application/pgp-signature + +-----BEGIN PGP SIGNATURE----- +Version: GnuPG v1.4.11 (GNU/Linux) + +iEYEARECAAYFAk8T6gYACgkQaezQq/BJZRZ0EQCcC/YqvlEOonCwA8D/oHjy2he5 +GmAAn2oNgiUBUSpVwHXJ9uVpXUXLFHYW +=CgtL +-----END PGP SIGNATURE----- +--=-=-=-- -- 2.26.2