From 4bdd94157f919b8186abfaf09cffd76bf06c4ab4 Mon Sep 17 00:00:00 2001 From: Jani Nikula Date: Sat, 24 Jan 2015 22:04:20 +0200 Subject: [PATCH] Re: [PATCH 2/3] notmuch-mutt: support for messages that lack Message-ID headers --- 23/30b2d353228a2726c0499c0429196e009fbfff | 97 +++++++++++++++++++++++ 1 file changed, 97 insertions(+) create mode 100644 23/30b2d353228a2726c0499c0429196e009fbfff diff --git a/23/30b2d353228a2726c0499c0429196e009fbfff b/23/30b2d353228a2726c0499c0429196e009fbfff new file mode 100644 index 000000000..4535beb43 --- /dev/null +++ b/23/30b2d353228a2726c0499c0429196e009fbfff @@ -0,0 +1,97 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id BE552431FAF + for ; Sat, 24 Jan 2015 12:04:16 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.738 +X-Spam-Level: * +X-Spam-Status: No, score=1.738 tagged_above=-999 required=5 + tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id t0Gp+FUpb8WM for ; + Sat, 24 Jan 2015 12:04:13 -0800 (PST) +Received: from mail-we0-f173.google.com (mail-we0-f173.google.com + [74.125.82.173]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id B4A54431FAE + for ; Sat, 24 Jan 2015 12:04:12 -0800 (PST) +Received: by mail-we0-f173.google.com with SMTP id w62so3007604wes.4 + for ; Sat, 24 Jan 2015 12:04:10 -0800 (PST) +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:from:to:subject:in-reply-to:references + :user-agent:date:message-id:mime-version:content-type; + bh=JZ+ZCDE1s7YHZksy7xxNjbJysOLdiG7tYJR1X9WSvTs=; + b=cFOE2ouqurwtFAJ/Hr+ekIzX6YOgWGtf/h+uaP3Gl9hVPpAIghhol0ZKqDFtBYFPMR + X3WCjwtUthUNE2Q62zlT1Sbbo0ByB4TOvMBbOJFokXD7/Mr5XFHQ2CNB71Fyf7CC6EUn + HcJxK69SkQ3ic1OSlxKtjhUVnrNukQ322NXi4L6xr8ObZH9KBF5nAlGHNmpvwY8KjNDt + ESDTwo8z56rVhaCCwWf5e7lcx87Ehirtr19tBIsg1FX7P2fF05+EK0F1wCkQMznryIwn + ma5zTLQF6z2+PsdnHaYCU0QwmZQlOPGvKh2c4SJuav7LptCmaL1SD6FsNz4m8NnHtpK8 + NiDw== +X-Gm-Message-State: + ALoCoQk1m2mMDbbMkenHc5yT6upx49UQx+bKGUOe37raRulJtKsr6z4NQDILUKFSQLsMm915MOEY +X-Received: by 10.194.222.136 with SMTP id qm8mr28157892wjc.116.1422129850310; + Sat, 24 Jan 2015 12:04:10 -0800 (PST) +Received: from localhost (mobile-internet-bcee98-87.dhcp.inet.fi. + [188.238.152.87]) + by mx.google.com with ESMTPSA id ha1sm7042734wib.24.2015.01.24.12.04.09 + (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Sat, 24 Jan 2015 12:04:09 -0800 (PST) +From: Jani Nikula +To: "Jan N. Klug" , notmuch@notmuchmail.org +Subject: Re: [PATCH 2/3] notmuch-mutt: support for messages that + lack Message-ID headers +In-Reply-To: <20150124165639.GA1316@mobil-13.rubion.rub.de> +References: <1422090701-19385-1-git-send-email-zack@upsilon.cc> + <1422090701-19385-3-git-send-email-zack@upsilon.cc> + <871tmkql6j.fsf@nikula.org> <20150124152106.GA23037@upsilon.cc> + <20150124165639.GA1316@mobil-13.rubion.rub.de> +User-Agent: Notmuch/0.19+37~g290dc80 (http://notmuchmail.org) Emacs/24.4.1 + (x86_64-pc-linux-gnu) +Date: Sat, 24 Jan 2015 22:04:20 +0200 +Message-ID: <87y4ososhn.fsf@nikula.org> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sat, 24 Jan 2015 20:04:16 -0000 + +On Sat, 24 Jan 2015, "Jan N. Klug" wrote: +> On Sat, Jan 24, 2015 at 04:21:06PM +0100, Stefano Zacchiroli wrote: +>> On Sat, Jan 24, 2015 at 04:59:16PM +0200, Jani Nikula wrote: +>> > On Sat, 24 Jan 2015, Stefano Zacchiroli wrote: +>> > > To do the above, rewrite get_message_id() to scan the current message +>> > > line by line, incrementally computing a SHA1. As a consequence, drop +>> > > the dependency on Mail::Internet. +>> > +>> > I am not so sure this is a good idea however, see below. +>> [...] +>> But I didn't think of header folding, and you're absolutely correct in +>> saying that might be a problem. +> +> I disagree. I do not think that header folding is a problem here. RFC +> 5322 and RFC 2822 state that FWS in the message-id are not allowed (as +> opposed to In-Reply: and other headers, where FWS may occur between, but +> not inside message-ids). + +Not *inside* message-ids, but as a data point, 0.05% of my email have +FWS *before* the message-id. That's more than the amount of messages +I have without a message-id. + +BR, +Jani. -- 2.26.2