From 4b3ed917473b00e7d5fc7943351a3538eddac627 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Wed, 8 Apr 2015 18:04:18 +0300 Subject: [PATCH] Re: [PATCH 1/2] test: be consistent about spelling `nonexistent' --- 01/29f66b3ddcef4eb1a2ad0851aedc2c92e607e3 | 108 ++++++++++++++++++++++ 1 file changed, 108 insertions(+) create mode 100644 01/29f66b3ddcef4eb1a2ad0851aedc2c92e607e3 diff --git a/01/29f66b3ddcef4eb1a2ad0851aedc2c92e607e3 b/01/29f66b3ddcef4eb1a2ad0851aedc2c92e607e3 new file mode 100644 index 000000000..219619cfe --- /dev/null +++ b/01/29f66b3ddcef4eb1a2ad0851aedc2c92e607e3 @@ -0,0 +1,108 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 9FC826DE1767 + for ; Wed, 8 Apr 2015 08:04:50 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: 1.167 +X-Spam-Level: * +X-Spam-Status: No, score=1.167 tagged_above=-999 required=5 tests=[AWL=0.515, + SPF_NEUTRAL=0.652] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id k58ec8c0KcWU for ; + Wed, 8 Apr 2015 08:04:44 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by arlo.cworth.org (Postfix) with ESMTP id EB5526DE1607 + for ; Wed, 8 Apr 2015 08:04:43 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id 0543F10019F; + Wed, 8 Apr 2015 18:04:19 +0300 (EEST) +From: Tomi Ollila +To: David Bremner , David Bremner , + notmuch@notmuchmail.org +Subject: Re: [PATCH 1/2] test: be consistent about spelling `nonexistent' +In-Reply-To: <1428504337-18362-1-git-send-email-david@tethera.net> +References: + <1428504337-18362-1-git-send-email-david@tethera.net> +User-Agent: Notmuch/0.19+107~gab55bdb (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.18 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 08 Apr 2015 15:04:50 -0000 + +On Wed, Apr 08 2015, David Bremner wrote: + +> Apparently most of the misspellings are my fault. + +Series LGTM. Tests pass. + +Tomi + + +> --- +> test/T360-symbol-hiding.sh | 2 +- +> test/T560-lib-error.sh | 2 +- +> test/symbol-test.cc | 2 +- +> 3 files changed, 3 insertions(+), 3 deletions(-) +> +> diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh +> index 8fc4bdf..d2b5d1f 100755 +> --- a/test/T360-symbol-hiding.sh +> +++ b/test/T360-symbol-hiding.sh +> @@ -16,7 +16,7 @@ run_test(){ +> } +> +> output="A Xapian exception occurred opening database: Couldn't stat 'fakedb/.notmuch/xapian' +> -caught No chert database found at path \`./nonexistant'" +> +caught No chert database found at path \`./nonexistent'" +> +> mkdir -p fakedb/.notmuch +> +> diff --git a/test/T560-lib-error.sh b/test/T560-lib-error.sh +> index 828a44b..6947aa8 100755 +> --- a/test/T560-lib-error.sh +> +++ b/test/T560-lib-error.sh +> @@ -202,7 +202,7 @@ test_begin_subtest "Xapian exception finding message" +> cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} +> { +> notmuch_message_t *message = NULL; +> - stat = notmuch_database_find_message (db, "id:nonexistant", &message); +> + stat = notmuch_database_find_message (db, "id:nonexistent", &message); +> } +> EOF +> sed 's/^\(A Xapian exception [^:]*\):.*$/\1/' < OUTPUT > OUTPUT.clean +> diff --git a/test/symbol-test.cc b/test/symbol-test.cc +> index d979f83..f17ddc8 100644 +> --- a/test/symbol-test.cc +> +++ b/test/symbol-test.cc +> @@ -15,7 +15,7 @@ int main() { +> } +> +> try { +> - (void) new Xapian::WritableDatabase("./nonexistant", Xapian::DB_OPEN); +> + (void) new Xapian::WritableDatabase("./nonexistent", Xapian::DB_OPEN); +> } catch (const Xapian::Error &error) { +> printf("caught %s\n", error.get_msg().c_str()); +> return 0; +> -- +> 2.1.4 -- 2.26.2