From 482718bb4a7209601bd57551816c428554bd052f Mon Sep 17 00:00:00 2001 From: David Bremner Date: Tue, 24 Nov 2015 08:52:02 +2000 Subject: [PATCH] Re: [PATCH] forbid atomic transactions on writable, upgradable databases --- 52/6c159aab41fc1ff75cb7a0b339a8ac58a65c99 | 63 +++++++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 52/6c159aab41fc1ff75cb7a0b339a8ac58a65c99 diff --git a/52/6c159aab41fc1ff75cb7a0b339a8ac58a65c99 b/52/6c159aab41fc1ff75cb7a0b339a8ac58a65c99 new file mode 100644 index 000000000..84687d9f6 --- /dev/null +++ b/52/6c159aab41fc1ff75cb7a0b339a8ac58a65c99 @@ -0,0 +1,63 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 20DC16DE0FFA + for ; Mon, 23 Nov 2015 04:52:10 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.551 +X-Spam-Level: +X-Spam-Status: No, score=-0.551 tagged_above=-999 required=5 + tests=[RP_MATCHES_RCVD=-0.55, SPF_PASS=-0.001] autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kWsQ23xifcFk for ; + Mon, 23 Nov 2015 04:52:07 -0800 (PST) +X-Greylist: delayed 357 seconds by postgrey-1.35 at arlo; + Mon, 23 Nov 2015 04:52:07 PST +Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) + by arlo.cworth.org (Postfix) with ESMTPS id 509116DE0943 + for ; Mon, 23 Nov 2015 04:52:07 -0800 (PST) +Received: from remotemail by fethera.tethera.net with local (Exim 4.84) + (envelope-from ) + id 1a0qbD-0000VA-6G; Mon, 23 Nov 2015 07:52:03 -0500 +Received: (nullmailer pid 6638 invoked by uid 1000); + Mon, 23 Nov 2015 12:52:02 -0000 +From: David Bremner +To: Steven Allen , notmuch@notmuchmail.org +Subject: Re: [PATCH] forbid atomic transactions on writable, + upgradable databases +In-Reply-To: <1445808639-5378-1-git-send-email-steven@stebalien.com> +References: <1445808639-5378-1-git-send-email-steven@stebalien.com> +User-Agent: Notmuch/0.21+7~g55fb7da (http://notmuchmail.org) Emacs/24.5.1 + (x86_64-pc-linux-gnu) +Date: Mon, 23 Nov 2015 08:52:02 -0400 +Message-ID: <87oaek5159.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Mon, 23 Nov 2015 12:52:10 -0000 + +Steven Allen writes: + +> 1. There is no reason to call `begin_atomic` unless you intend to to +> write to the database and anyone intending to write to the database +> should upgrade it first. +> 2. This means that nothing inside an atomic transaction can ever fail +> with NOTMUCH_STATUS_UPGRADE_REQUIRED. + +Applied to master + +d -- 2.26.2