From 48262df85b600ca39b631c99702fd1208303646c Mon Sep 17 00:00:00 2001 From: Mark Walters Date: Fri, 6 Jun 2014 14:12:28 +0100 Subject: [PATCH] Re: [PATCH v2] emacs: Add support for saved search accelerators --- 7f/2af55b3576806fbe1b2d20eef0c30eb1f79931 | 113 ++++++++++++++++++++++ 1 file changed, 113 insertions(+) create mode 100644 7f/2af55b3576806fbe1b2d20eef0c30eb1f79931 diff --git a/7f/2af55b3576806fbe1b2d20eef0c30eb1f79931 b/7f/2af55b3576806fbe1b2d20eef0c30eb1f79931 new file mode 100644 index 000000000..c939e1cab --- /dev/null +++ b/7f/2af55b3576806fbe1b2d20eef0c30eb1f79931 @@ -0,0 +1,113 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 29DB540C445 + for ; Fri, 6 Jun 2014 06:12:56 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0.502 +X-Spam-Level: +X-Spam-Status: No, score=0.502 tagged_above=-999 required=5 + tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, + NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id ene+-cVxR5-6 for ; + Fri, 6 Jun 2014 06:12:52 -0700 (PDT) +Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) + (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 87EED40B039 + for ; Fri, 6 Jun 2014 06:12:52 -0700 (PDT) +Received: from smtp.qmul.ac.uk ([138.37.6.40]) + by mail2.qmul.ac.uk with esmtp (Exim 4.71) + (envelope-from ) + id 1Wstww-00070H-9F; Fri, 06 Jun 2014 14:12:50 +0100 +Received: from 5751dfa2.skybroadband.com ([87.81.223.162] helo=localhost) + by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71) + (envelope-from ) + id 1Wstwb-0002ka-Td; Fri, 06 Jun 2014 14:12:30 +0100 +From: Mark Walters +To: David Edmondson , Aaron Ecay , + notmuch@notmuchmail.org +Subject: Re: [PATCH v2] emacs: Add support for saved search accelerators +In-Reply-To: +References: <1399385776-19918-1-git-send-email-dme@dme.org> + <1399461694-25350-1-git-send-email-dme@dme.org> + <1399461694-25350-2-git-send-email-dme@dme.org> + <87zjislji0.fsf@qmul.ac.uk> <87oaz5uzco.fsf@gmail.com> + +User-Agent: Notmuch/0.15.2+615~g78e3a93 (http://notmuchmail.org) Emacs/23.4.1 + (x86_64-pc-linux-gnu) +Date: Fri, 06 Jun 2014 14:12:28 +0100 +Message-ID: <87y4xadvwj.fsf@qmul.ac.uk> +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-Sender-Host-Address: 87.81.223.162 +X-QM-Geographic: According to ripencc, + this message was delivered by a machine in Britain (UK) (GB). +X-QM-SPAM-Info: Sender has good ham record. :) +X-QM-Body-MD5: 33be7a01c88354b199659a5f2b9cd5a1 (of first 20000 bytes) +X-SpamAssassin-Score: -0.1 +X-SpamAssassin-SpamBar: / +X-SpamAssassin-Report: The QM spam filters have analysed this message to + determine if it is + spam. We require at least 5.0 points to mark a message as spam. + This message scored -0.1 points. + Summary of the scoring: + * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail + provider * (markwalters1009[at]gmail.com) + * -0.1 AWL AWL: From: address is in the auto white-list +X-QM-Scan-Virus: ClamAV says the message is clean +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Fri, 06 Jun 2014 13:12:56 -0000 + +On Mon, 12 May 2014, David Edmondson wrote: +> On Sat, May 10 2014, Aaron Ecay wrote: +>> 2014ko maiatzak 8an, Mark Walters-ek idatzi zuen: +>>> +>>> Hi +>>> +>>> This version looks good to me. +>>> +>>> The only slight query I have is which key to bind it to: Austin used g +>>> in notmuch-go and this uses j. Austin said on irc that he chose g +>>> because it wasn't bound and matched gmail's shortcut. +>>> +>>> Personally I like j (as it starts fewer words than g) and given that we +>>> don't match any of gmail's other bindings I don't think there is much +>>> advantage to doing so in this case. +>> +>> All other things being equal, I=E2=80=99d prefer =E2=80=9Cj=E2=80=9D her= +e, but for different +>> reasons. =E2=80=9Cg=E2=80=9D is the emacs-standard key to refresh or re= +vert a buffer. +>> In my personal customization file I bound =E2=80=9Cg=E2=80=9D to +>> notmuch-refresh-this-buffer in notmuch-(show/search)-mode-map long ago +>> (and forgot this binding was not standard until reading above that g is +>> not bound). It=E2=80=99s probably better emacs citizenship to not use s= +uch a +>> standard key for a different purpose. +> +> +1, though I won't lose sleep. + +That sounds like a consensus so +1 from me. + +Best wishes + +Mark + + -- 2.26.2