From 47fdfe52bbd15035a39549b0e9580ff5fd870b92 Mon Sep 17 00:00:00 2001 From: David Edmondson Date: Tue, 9 Feb 2016 20:47:20 +0000 Subject: [PATCH] Re: [PATCH v2 (rebased) 0/3] Improve the display of matching/non-matching authors. --- 53/c5e7037899a65a3f191636d5c22bcbe56707e6 | 129 ++++++++++++++++++++++ 1 file changed, 129 insertions(+) create mode 100644 53/c5e7037899a65a3f191636d5c22bcbe56707e6 diff --git a/53/c5e7037899a65a3f191636d5c22bcbe56707e6 b/53/c5e7037899a65a3f191636d5c22bcbe56707e6 new file mode 100644 index 000000000..ced968955 --- /dev/null +++ b/53/c5e7037899a65a3f191636d5c22bcbe56707e6 @@ -0,0 +1,129 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by arlo.cworth.org (Postfix) with ESMTP id 834916DE17AC + for ; Tue, 9 Feb 2016 12:47:26 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at cworth.org +X-Spam-Flag: NO +X-Spam-Score: -0.103 +X-Spam-Level: +X-Spam-Status: No, score=-0.103 tagged_above=-999 required=5 + tests=[AWL=-0.036, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, + RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, + RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001] + autolearn=disabled +Received: from arlo.cworth.org ([127.0.0.1]) + by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id FjJfJANSoOvn for ; + Tue, 9 Feb 2016 12:47:24 -0800 (PST) +Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com + [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id CF9136DE14FD for + ; Tue, 9 Feb 2016 12:47:23 -0800 (PST) +Received: by mail-wm0-f68.google.com with SMTP id 128so54950wmz.3 + for ; Tue, 09 Feb 2016 12:47:23 -0800 (PST) +DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=dme-org.20150623.gappssmtp.com; s=20150623; + h=to:subject:in-reply-to:references:from:date:message-id:mime-version + :content-type; bh=0FyHo+o0ebigwmPtCABNACW3c2At4znIh5BbaGM9NtE=; + b=isf/WtiHu7u0Bg5Qkwa+bd0814cBT6t0qrUZOujDJS8YXLsK+pCeyakUYWnHW7QEop + 09bCkYmG/MmeU2CWb6gNZhiA7nFC9my7e81jfVkv75ZPzduLPW+b5XKakUeajx+VlBUu + 6+HRbjI7LvFn8spvw7FQc5FV6blc8Z/1LDzJsfr3zx9RfavTgYlKEKPgFu0kqmjp/mqL + 0LwbLv8fp8Z+dj2lBTmfxRN29JGPRfElEByg6IjvaGiv2buoEHtTXglLWBOTLd8+Pz68 + OE15o5gH/BxEc3TA0oCOFM6P+arBDghhYA+TDXU+kwLKGxPM0hPx6zTEIizy4xtcO9PN + GfwQ== +X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; + d=1e100.net; s=20130820; + h=x-gm-message-state:to:subject:in-reply-to:references:from:date + :message-id:mime-version:content-type; + bh=0FyHo+o0ebigwmPtCABNACW3c2At4znIh5BbaGM9NtE=; + b=ifOxbmg5peh9MfEkOmU2H/w/UH8y6dlIfePC+KZK9CmvezXj0LbfAFwaYPwF3EWadE + QFz0bWbNcYNCgsNomkoCHTrLExnIkLA33PNCImQDcnqkrkSJmogfFsjPBjuqG5mXYPVQ + 6AdAqtd/9gNOuC2YG1j8YOdEdT+P6IxfdV8E0rZLmsSOe+CnH720/C6wamm4FbroLJjX + SlO8WH0sTliEMXGudyeNGKZOH5/0wAxdiYT3g1V6rZT8ScqyI5THFjUcDQ9bPMrAypSx + NxxJadqXguTQn/keALNFEGqugGo3kaKC6yjduGrzZ7CaWJfPVT1KnvKyv7Mw3NCUAL4Z + DnLQ== +X-Gm-Message-State: + AG10YOS6STSuZQGoeITT4WdxAYVuP4vOMTGpixpVz0VKPWKlZklWXn4KfdkObQkytHnpVw== +X-Received: by 10.194.85.161 with SMTP id i1mr40269626wjz.95.1455050842528; + Tue, 09 Feb 2016 12:47:22 -0800 (PST) +Received: from disaster-area.hh.sledj.net + ([2a01:348:1a2:1:ea39:35ff:fe2c:a227]) + by smtp.gmail.com with ESMTPSA id 73sm19354229wmm.7.2016.02.09.12.47.21 + (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); + Tue, 09 Feb 2016 12:47:21 -0800 (PST) +Received: from localhost (disaster-area.hh.sledj.net [local]) + by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id e9092be3; + Tue, 9 Feb 2016 20:47:20 +0000 (UTC) +To: Mark Walters , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 (rebased) 0/3] Improve the display of + matching/non-matching authors. +In-Reply-To: <1450113766-20518-1-git-send-email-markwalters1009@gmail.com> +References: <1450113766-20518-1-git-send-email-markwalters1009@gmail.com> +From: David Edmondson +Date: Tue, 09 Feb 2016 20:47:20 +0000 +Message-ID: +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.20 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 09 Feb 2016 20:47:26 -0000 + +On Mon, Dec 14 2015, Mark Walters wrote: +> This is just a rebased (to current master) version of +> id:1414172643-28270-1-git-send-email-dme@dme.org (git did the rebase by +> itself using a three-way merge) +> +> I will send some review comments as replies to this thread. + +I didn't see any, but in general I think: + +- the core notmuch changes should be okay to commit (presuming that they + still apply cleanly), +- the emacs UI changes need some careful consideration. There is some + small loss of functionality alluded to in + id:1414172643-28270-1-git-send-email-dme@dme.org: + + % - More improvements to the code that renders the authors are possible + % (to improve the chosen break between visible and invisible), but a + % planned re-write of the `notmuch-search-result-format' code would + % render that irrelevant. + + Fixing that properly requires the further changes to how search + results are presented. Those changes were never finished. + +> +> Best wishes +> +> Mark +> +> +> David Edmondson (3): +> search: Separately report matching and non-matching authors. +> emacs: Improved display of matching/non-matching authors. +> test: Update tests for 'authors_matched' and authors_non_matched'. +> +> emacs/notmuch.el | 64 ++++++++++++++------------ +> notmuch-search.c | 105 +++++++++++++++++++++++++++++++++++++++++++ +> test/T160-json.sh | 9 ++++ +> test/T170-sexp.sh | 4 +- +> test/T470-missing-headers.sh | 8 ++++ +> 5 files changed, 159 insertions(+), 31 deletions(-) +> +> -- +> 2.1.4 +> +> _______________________________________________ +> notmuch mailing list +> notmuch@notmuchmail.org +> https://notmuchmail.org/mailman/listinfo/notmuch -- 2.26.2