From 472d3fba7db7184fee3c4122d8f628cd6436c6bc Mon Sep 17 00:00:00 2001 From: Joey Hess Date: Sun, 4 Jul 2010 16:08:54 -0400 Subject: [PATCH] comment --- doc/plugins/po.mdwn | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/doc/plugins/po.mdwn b/doc/plugins/po.mdwn index fab6053b3..fe4d75748 100644 --- a/doc/plugins/po.mdwn +++ b/doc/plugins/po.mdwn @@ -266,6 +266,14 @@ to an array to support this. (If twere done, twere best done quickly.) > Done in my po branch, preserving backward compatibility. Please > review :) --[[intrigeri]] +>> Right, well my immediate concern is that using an array to hold +>> hash-like pairs is not very clear to the user. It will be displayed +>> in a confusing way by websetup; dumping a setup file will probably +>> also cause it to be formatted in a confusing way. And the code +>> seems to assume that the array length is even, and probably blows +>> up if it is not.. and the value is marked safe so websetup can be +>> used to modify it and break that way too. --[[Joey]] + Pagespecs --------- -- 2.26.2