From 4503934aff43e5c661dd3e214f6b732778683a79 Mon Sep 17 00:00:00 2001 From: Tomi Ollila Date: Tue, 28 Oct 2014 23:19:49 +0200 Subject: [PATCH] Re: [PATCH v4 0/6] notmuch search --output=sender/recipients --- 7d/b9e18738e626759cc28bbb6bfe69aa4f4402b5 | 139 ++++++++++++++++++++++ 1 file changed, 139 insertions(+) create mode 100644 7d/b9e18738e626759cc28bbb6bfe69aa4f4402b5 diff --git a/7d/b9e18738e626759cc28bbb6bfe69aa4f4402b5 b/7d/b9e18738e626759cc28bbb6bfe69aa4f4402b5 new file mode 100644 index 000000000..edae9a38b --- /dev/null +++ b/7d/b9e18738e626759cc28bbb6bfe69aa4f4402b5 @@ -0,0 +1,139 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 6BAFF431FBC + for ; Tue, 28 Oct 2014 14:20:15 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id n1cwre3GxeyK for ; + Tue, 28 Oct 2014 14:20:07 -0700 (PDT) +Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) + by olra.theworths.org (Postfix) with ESMTP id A4079431FB6 + for ; Tue, 28 Oct 2014 14:20:06 -0700 (PDT) +Received: from guru.guru-group.fi (localhost [IPv6:::1]) + by guru.guru-group.fi (Postfix) with ESMTP id DD812100051; + Tue, 28 Oct 2014 23:19:49 +0200 (EET) +From: Tomi Ollila +To: Michal Sojka , notmuch@notmuchmail.org +Subject: Re: [PATCH v4 0/6] notmuch search --output=sender/recipients +In-Reply-To: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz> +References: <1414421455-3037-1-git-send-email-sojkam1@fel.cvut.cz> +User-Agent: Notmuch/0.18.1+130~ga61922f (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-unknown-linux-gnu) +X-Face: HhBM'cA~ +MIME-Version: 1.0 +Content-Type: text/plain; charset=utf-8 +Content-Transfer-Encoding: quoted-printable +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Tue, 28 Oct 2014 21:20:15 -0000 + +On Mon, Oct 27 2014, Michal Sojka wrote: + +> Hi all, +> +> this is v4 of the search --output=3Daddress series. It obsoletes v3 that +> starts at id:1413150093-8383-1-git-send-email-sojkam1@fel.cvut.cz. +> +> It addresses most comments made by Mark Walters and others. In +> addition to v3, it also implements new --output=3Dcount (also suggested +> by Mark). This required changes even in the initial patches of the +> series but the result is cleaner code. + +I looked through the messages + + id:1414421455-3037-2-git-send-email-sojkam1@fel.cvut.cz + id:1414421455-3037-3-git-send-email-sojkam1@fel.cvut.cz + id:1414421455-3037-4-git-send-email-sojkam1@fel.cvut.cz + id:1414421455-3037-5-git-send-email-sojkam1@fel.cvut.cz + +First I read the changes in this email thread and then changes in each of +these messages with xxdiff(1) -- and applied the patches and ran tests +(which passed). + +These 4 patches LGTM. + +The filtering/uniqueness whatnot handling still =C2=A1IMO! has things to ho= +pe +for, which I will write later... + +Finally, a promise I made a in reply to another patch series: Although +these emails are patches when sent to this mailing list, when these +are applied and pushed to notmuch repository the commit message should +not refer these as patches -- and therefore the email part that will +eventually be in commit message should be written differently. But that +is not a reason enough to require patch email resent. + + +Tomi + + +> +> Detailed changes from v3: +> +> - `o' renamed to `opt'. +> - Conversion of --output from keyword to keyword-flags is now a +> separate patch. +> - Structured output formats print name and address separately. +> - Added test for --format=3Djson. +> - Changed --filter-by default to nameaddr. In v2, the default was +> addrfold, in v3 the default was no filtering at all. I believe that +> Mark's suggestion to make nameaddr the default is good trade off. +> - Added new --output=3Dcount +> - Minor style fixes +> - Few typos fixed +> - There is no way to output unfiltered (duplicite) addresses. +> Hopefully, the introduction of --output=3Dcount is sufficient +> replacement for this "feature". +> +> Cheers, +> -Michal +> +> +> Jani Nikula (1): +> cli: Add support for parsing keyword-flag arguments +> +> Michal Sojka (5): +> cli: search: Refactor passing of command line options +> cli: search: Convert --output to keyword-flag argument +> cli: search: Add --output=3D{sender,recipients} +> cli: search: Add configurable way to filter out duplicate addresses +> cli: search: Add --output=3Dcount +> +> command-line-arguments.c | 6 +- +> command-line-arguments.h | 1 + +> completion/notmuch-completion.bash | 8 +- +> completion/notmuch-completion.zsh | 4 +- +> doc/man1/notmuch-search.rst | 65 ++++++- +> notmuch-search.c | 385 +++++++++++++++++++++++++++++--= +------ +> test/T090-search-output.sh | 137 +++++++++++++ +> test/T095-search-filter-by.sh | 64 ++++++ +> test/T410-argument-parsing.sh | 3 +- +> test/arg-test.c | 9 + +> 10 files changed, 600 insertions(+), 82 deletions(-) +> create mode 100755 test/T095-search-filter-by.sh +> +> --=20 +> 2.1.1 -- 2.26.2