From 43b281a0e871bbbb4f26bf7fb1f8fc6de432aa29 Mon Sep 17 00:00:00 2001 From: David Bremner Date: Sun, 5 Oct 2014 11:07:12 +0200 Subject: [PATCH] Re: [PATCH 00/11] Add ghost messages and fix thread linking --- 9a/97e88e71ab256a475024d5d146234a321beab5 | 68 +++++++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 9a/97e88e71ab256a475024d5d146234a321beab5 diff --git a/9a/97e88e71ab256a475024d5d146234a321beab5 b/9a/97e88e71ab256a475024d5d146234a321beab5 new file mode 100644 index 000000000..ad734655f --- /dev/null +++ b/9a/97e88e71ab256a475024d5d146234a321beab5 @@ -0,0 +1,68 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 90499431FBC + for ; Sun, 5 Oct 2014 02:07:30 -0700 (PDT) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id j20uJifcZivv for ; + Sun, 5 Oct 2014 02:07:25 -0700 (PDT) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id D7160431FB6 + for ; Sun, 5 Oct 2014 02:07:25 -0700 (PDT) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1Xahml-0007oy-4D; Sun, 05 Oct 2014 06:07:23 -0300 +Received: (nullmailer pid 24422 invoked by uid 1000); Sun, 05 Oct 2014 + 09:07:12 -0000 +From: David Bremner +To: Austin Clements , notmuch@notmuchmail.org +Subject: Re: [PATCH 00/11] Add ghost messages and fix thread linking +In-Reply-To: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> +References: <1412345958-8278-1-git-send-email-aclements@csail.mit.edu> +User-Agent: Notmuch/0.18.1+98~gae27403 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Sun, 05 Oct 2014 11:07:12 +0200 +Message-ID: <87a95aq3zz.fsf@maritornes.cs.unb.ca> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Sun, 05 Oct 2014 09:07:30 -0000 + +Austin Clements writes: + +> This series modifies our database representation of messages that have +> been referenced by other messages, but for which we don't have the +> message itself. Currently, we store this information as Xapian +> metadata, but this has several downsides for performance and +> complexity and results in hard-to-fix thread linking bugs. This patch +> series implements "ghost messages", which replace this Xapian metadata +> with Xapian documents that look and act very much like regular message +> documents, but simply have no content. This simplifies and speeds up +> our thread linking algorithm and fixes the currently broken thread +> linking test. + +Other than some style / documentation quibbles already noted, +the series looks good to me. + +d -- 2.26.2