From 430b0e4f51a584fe6c65482da813631228095e8a Mon Sep 17 00:00:00 2001 From: David Bremner Date: Wed, 15 Jan 2014 20:29:01 +2000 Subject: [PATCH] Re: [PATCH 1/1] test: leave T\d\d\d- in variable $this_test and introduce $this_test_bare --- 95/a2908447f0419d38ee23bd1547ce802eabe6c4 | 69 +++++++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 95/a2908447f0419d38ee23bd1547ce802eabe6c4 diff --git a/95/a2908447f0419d38ee23bd1547ce802eabe6c4 b/95/a2908447f0419d38ee23bd1547ce802eabe6c4 new file mode 100644 index 000000000..9433b31f6 --- /dev/null +++ b/95/a2908447f0419d38ee23bd1547ce802eabe6c4 @@ -0,0 +1,69 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 65EEB431FAF + for ; Tue, 14 Jan 2014 16:29:15 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 1.312 +X-Spam-Level: * +X-Spam-Status: No, score=1.312 tagged_above=-999 required=5 + tests=[GAPPY_SUBJECT=1.312] autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id K1WHBVTePXy9 for ; + Tue, 14 Jan 2014 16:29:09 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 07040431FAE + for ; Tue, 14 Jan 2014 16:29:08 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W3ELx-0001hu-DD; Tue, 14 Jan 2014 20:29:05 -0400 +Received: (nullmailer pid 834 invoked by uid 1000); Wed, 15 Jan 2014 00:29:01 + -0000 +From: David Bremner +To: Tomi Ollila , notmuch@notmuchmail.org +Subject: Re: [PATCH 1/1] test: leave T\d\d\d- in variable $this_test and + introduce $this_test_bare +In-Reply-To: <1389645491-7600-1-git-send-email-tomi.ollila@iki.fi> +References: <1389280739-31930-1-git-send-email-tomi.ollila@iki.fi> + <1389645491-7600-1-git-send-email-tomi.ollila@iki.fi> +User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Tue, 14 Jan 2014 20:29:01 -0400 +Message-ID: <877ga2jdf6.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +Cc: tomi.ollila@iki.fi +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Jan 2014 00:29:15 -0000 + +Tomi Ollila writes: + +> Script `notmuch-test` expects the results file have T\d\d\d- part +> intact so the results files (and some test output files) are now named +> as such. +> +> The T\d\d\d- part is dropped in new variable $this_test_bare which is used +> in progress informational messages and when loading .el files in emacs +> tests (whenever $this_test_bare.el exists). + +Should this commit message mention the bug it fixes? + +Other than that the patch looks ok. + +d -- 2.26.2