From 4108473c173f5bb4262618ac479902bc82e3009a Mon Sep 17 00:00:00 2001 From: David Bremner Date: Thu, 16 Jan 2014 14:03:06 +2000 Subject: [PATCH] Re: [PATCH v2 0/7] lib: replace the message header parser with gmime --- 8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 | 75 +++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 diff --git a/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 b/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 new file mode 100644 index 000000000..5f164936a --- /dev/null +++ b/8c/ee8c9c5dfc44d42c748ef8dd906c8c8b58aff0 @@ -0,0 +1,75 @@ +Return-Path: +X-Original-To: notmuch@notmuchmail.org +Delivered-To: notmuch@notmuchmail.org +Received: from localhost (localhost [127.0.0.1]) + by olra.theworths.org (Postfix) with ESMTP id 18A75431FBD + for ; Wed, 15 Jan 2014 10:03:22 -0800 (PST) +X-Virus-Scanned: Debian amavisd-new at olra.theworths.org +X-Spam-Flag: NO +X-Spam-Score: 0 +X-Spam-Level: +X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] + autolearn=disabled +Received: from olra.theworths.org ([127.0.0.1]) + by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) + with ESMTP id kxjfNEXX5el4 for ; + Wed, 15 Jan 2014 10:03:14 -0800 (PST) +Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) + (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) + (No client certificate requested) + by olra.theworths.org (Postfix) with ESMTPS id 83439431FAF + for ; Wed, 15 Jan 2014 10:03:14 -0800 (PST) +Received: from remotemail by yantan.tethera.net with local (Exim 4.80) + (envelope-from ) + id 1W3Uo3-0007WZ-5c; Wed, 15 Jan 2014 14:03:11 -0400 +Received: (nullmailer pid 8859 invoked by uid 1000); Wed, 15 Jan 2014 + 18:03:06 -0000 +From: David Bremner +To: Jani Nikula , notmuch@notmuchmail.org +Subject: Re: [PATCH v2 0/7] lib: replace the message header parser with gmime +In-Reply-To: +References: +User-Agent: Notmuch/0.17+30~g50677dd (http://notmuchmail.org) Emacs/24.3.1 + (x86_64-pc-linux-gnu) +Date: Wed, 15 Jan 2014 14:03:06 -0400 +Message-ID: <87ob3di0md.fsf@zancas.localnet> +MIME-Version: 1.0 +Content-Type: text/plain +X-BeenThere: notmuch@notmuchmail.org +X-Mailman-Version: 2.1.13 +Precedence: list +List-Id: "Use and development of the notmuch mail system." + +List-Unsubscribe: , + +List-Archive: +List-Post: +List-Help: +List-Subscribe: , + +X-List-Received-Date: Wed, 15 Jan 2014 18:03:22 -0000 + +Jani Nikula writes: + +> This is v2 of id:cover.1381948853.git.jani@nikula.org with more polish. +> +> Patches 1-4 do prep work to fix some of the differences in the parsers +> in advance. Arguably they are not that bad regardless of the parser +> change. +> +> Patches 5-6 actually make the change. Having two patches is a somewhat +> artificial division, but perhaps makes it easier to review. +> + +I had a quick look at these changes, and nothing jumped out at me. I'd +appreciate a second pair of eyes on them. + +I ran the performance suite, and there is only one message (in version +0.4 of the corpus) newly classified as non-mail. Of course I did clean +up the corpus a bunch from 0.3 to 0.4. I didn't see any shocking changes +in performance before and after the patches. I only had patience enough +to run twice in both cases. + +d + + -- 2.26.2